https://bugzilla.redhat.com/show_bug.cgi?id=1289717 --- Comment #19 from Ilya Gradina <ilya.gradina@xxxxxxxxx> --- (In reply to Igor Gnatenko from comment #17) > * Don't build examples as you don't really package it (you can put source > code of them in -devel subpackage if it's not huge amount of data) and > remove examples subpackage > * Remove all magic numbers and if you need to exclude some test, write link > to upstream bugreport > * Own %dir %{_datadir}/cmake > * Not sure if ./viennacl/tools/sha1.hpp used during compilation, if yes, > then License should look like "MIT and ISC" > * drop bundled opencl headers and use system ones from opencl-headers Hi Igor, thx! new spec: https://github.com/neurofedora/ViennaCL/raw/master/viennacl.spec new srpm: https://github.com/neurofedora/ViennaCL/raw/master/viennacl-1.7.1-2.fc26.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx