Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: avr-libc - C library for use with GCC on Atmel AVR microcontrollers https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241279 ------- Additional Comments From mebrown@xxxxxxxxxxxxxxxxxx 2007-07-13 16:55 EST ------- http://fedoraproject.org/wiki/Packaging/ReviewGuidelines Here are all the MUST items that have problems - MUST: The License field in the package spec file must match the actual license. --> NOT OK: project: modified BSD, package spec: GPL - MUST: Header files must be in a -devel package. --> hmm... discuss? (see rpmlint output) - MUST: Static libraries must be in a -static package. --> hmm... discuss? (see rpmlint output) Possible solution: split out -devel package and have avr-libc require: avr-libc-devel? Or possibly just rename the package. - MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} --> GOOD (no -devel package, but maybe need one considering other review items) - MUST: Packages must not own files or directories already owned by other packages. --> BAD $ rpm -qf /usr/avr avr-binutils- 2.17-3.fc7.x86_64 avr-libc- 1.4.6-1.x86_64 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review