https://bugzilla.redhat.com/show_bug.cgi?id=1396139 Peter Lemenkov <lemenkov@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #12 from Peter Lemenkov <lemenkov@xxxxxxxxx> --- To speedup things a little I'm going to steal this REVIEW: Legend: + = PASSED, - = FAILED, 0 = Not Applicable + rpmlint is not silent, but its messages are safe to ignore: Auriga ~/rpmbuild/SPECS: rpmlint ../RPMS/x86_64/libmad-* ../SRPMS/libmad-0.15.1b-19.fc25.src.rpm libmad.x86_64: E: incorrect-fsf-address /usr/share/licenses/libmad/COPYRIGHT libmad.x86_64: E: incorrect-fsf-address /usr/share/licenses/libmad/COPYING libmad-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/libmad-0.15.1b/layer12.c libmad-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/libmad-0.15.1b/layer3.c libmad-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/libmad-0.15.1b/version.c libmad-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/libmad-0.15.1b/decoder.c libmad-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/libmad-0.15.1b/version.h libmad-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/libmad-0.15.1b/synth.c libmad-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/libmad-0.15.1b/frame.h libmad-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/libmad-0.15.1b/stream.h libmad-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/libmad-0.15.1b/fixed.c libmad-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/libmad-0.15.1b/timer.h libmad-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/libmad-0.15.1b/timer.c libmad-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/libmad-0.15.1b/frame.c libmad-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/libmad-0.15.1b/huffman.c libmad-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/libmad-0.15.1b/decoder.h libmad-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/libmad-0.15.1b/bit.h libmad-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/libmad-0.15.1b/synth.h libmad-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/libmad-0.15.1b/bit.c libmad-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/libmad-0.15.1b/huffman.h libmad-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/libmad-0.15.1b/stream.c libmad-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/libmad-0.15.1b/fixed.h ^^^ This is safe to ignore. Regarding mentioning upstream - the application is ~12 years old, so it's likely it won't be updated anytime soon regardless of attempts to contact upstream. libmad-devel.x86_64: W: only-non-binary-in-usr-lib ^^^ false positive. libmad-devel.x86_64: W: no-documentation ^^^ That's how things are. It would be better if the package has documentation. unfortunately it hasn't. libmad-devel.x86_64: E: incorrect-fsf-address /usr/include/mad.h ^^^ See above. libmad.src: W: %ifarch-applied-patch Patch0: libmad-0.15.1b-multiarch.patch ^^^ This is intentional. 4 packages and 0 specfiles checked; 23 errors, 3 warnings. Auriga ~/rpmbuild/SPECS: + The package is named according to the Package Naming Guidelines. + The spec file name matches the base package %{name}, in the format %{name}.spec. + The package meets the Packaging Guidelines. All the issues mentioned in the comments above were addressed. + The package is licensed with a Fedora approved license (GPLv2 or later) and meets the Licensing Guidelines. + The License field in the package spec file matches the actual license (GPLv2 or later). + The file, containing the text of the license(s) for the package, is included as %license. + The spec file is written in American English. + The spec file for the package is legible. + The sources used to build the package, match the upstream source, as provided in the spec URL. Auriga ~/rpmbuild/SOURCES: sha256sum libmad-0.15.1b.tar.gz* bbfac3ed6bfbc2823d3775ebb931087371e142bb0e9bb1bee51a76a6e0078690 libmad-0.15.1b.tar.gz bbfac3ed6bfbc2823d3775ebb931087371e142bb0e9bb1bee51a76a6e0078690 libmad-0.15.1b.tar.gz.1 Auriga ~/rpmbuild/SOURCES: + The package successfully compiles and builds into binary rpms on at least one primary architecture. + All build dependencies are listed in BuildRequires. 0 No need to handle locales. + The package stores shared library files in some of the dynamic linker's default paths, and it calls ldconfig in %post and %postun. + The package does NOT bundle copies of system libraries. 0 The package is not designed to be relocatable. + The package owns all directories that it creates. + The package does not list a file more than once in the spec file's %files listings. + Permissions on files are set properly. + The package consistently uses macros. + The package contains code, or permissible content. 0 No extremely large documentation files. + Anything, the package includes as %doc, does not affect the runtime of the application. + Header files are stored in a -devel package. 0 No static libraries. + The pkgconfig(.pc) files are stored in a -devel package. + The library file(s) that end in .so (without suffix) is(are) stored in a -devel package. + The -devel package requires the base package using a fully versioned dependency: Requires: %{name}%{?_isa} = %{version}-%{release} + The package does NOT contain any .la libtool archives. 0 Not a GUI application. + The package does not own files or directories already owned by other packages. + All filenames in rpm packages are valid UTF-8. This package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx