https://bugzilla.redhat.com/show_bug.cgi?id=1398690 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #4 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL Source addresses are usable. Ok. Source archive is original (SHA-256: b2dba019d5dfde41217f10cfdc20ebd46c3deee00accef37097f1bf2597f5c9a). Ok. Summary verified from lib/Module/Extract/Use.pm. Ok. Description verified from lib/Module/Extract/Use.pm. OK. License verified from lib/Module/Extract/Use.pm, examples/extract_modules, LICENSE. Ok. No XS code, noarch BuildArch is Ok. Test::Manifest is not helpful. Ok. Build-requires are Ok. All test pass. Ok. $ rpmlint perl-Module-Extract-Use.spec ../SRPMS/perl-Module-Extract-Use-1.04-2.fc26.src.rpm ../RPMS/noarch/perl-Module-Extract-Use-1.04-2.fc26.noarch.rpm perl-Module-Extract-Use.src: W: spelling-error %description -l en_US eval -> veal, vela, val perl-Module-Extract-Use.src: W: spelling-error %description -l en_US pragmas -> pragmatism perl-Module-Extract-Use.noarch: W: spelling-error %description -l en_US eval -> veal, vela, val perl-Module-Extract-Use.noarch: W: spelling-error %description -l en_US pragmas -> pragmatism 2 packages and 1 specfiles checked; 0 errors, 4 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Module-Extract-Use-1.04-2.fc26.noarch.rpm drwxr-xr-x 2 root root 0 Nov 28 11:02 /usr/share/doc/perl-Module-Extract-Use -rw-r--r-- 1 root root 1329 Jan 4 2014 /usr/share/doc/perl-Module-Extract-Use/Changes -rw-r--r-- 1 root root 477 Jan 4 2014 /usr/share/doc/perl-Module-Extract-Use/README drwxr-xr-x 2 root root 0 Nov 28 11:02 /usr/share/doc/perl-Module-Extract-Use/examples -rw-r--r-- 1 root root 2234 Jan 4 2014 /usr/share/doc/perl-Module-Extract-Use/examples/extract_modules drwxr-xr-x 2 root root 0 Nov 28 11:02 /usr/share/licenses/perl-Module-Extract-Use -rw-r--r-- 1 root root 69 Jan 4 2014 /usr/share/licenses/perl-Module-Extract-Use/LICENSE -rw-r--r-- 1 root root 2246 Nov 28 11:02 /usr/share/man/man3/Module::Extract::Use.3pm.gz drwxr-xr-x 2 root root 0 Nov 28 11:02 /usr/share/perl5/vendor_perl/Module drwxr-xr-x 2 root root 0 Nov 28 11:02 /usr/share/perl5/vendor_perl/Module/Extract -rw-r--r-- 1 root root 4847 Jan 4 2014 /usr/share/perl5/vendor_perl/Module/Extract/Use.pm File layout and permission are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Module-Extract-Use-1.04-2.fc26.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.24.0) 1 perl(PPI) 1 perl(strict) 1 perl(subs) 1 perl(vars) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Module-Extract-Use-1.04-2.fc26.noarch.rpm | sort -f | uniq -c 1 perl(Module::Extract::Use) = 1.04 1 perl-Module-Extract-Use = 1.04-2.fc26 The private Module::Extract::Use::Item module not provides. Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Module-Extract-Use-1.04-2.fc26.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F26 (http://koji.fedoraproject.org/koji/taskinfo?taskID=16655383). Ok. The package is in line with Fedora and Perl packaging guidelines. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx