https://bugzilla.redhat.com/show_bug.cgi?id=1358149 Shawn Iwinski <shawn@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #4 from Shawn Iwinski <shawn@xxxxxxxx> --- [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [!]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [!]: Buildroot is not present Note: Buildroot: present but not needed [!]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required As usual, remove EPEL 5 bits after initial import Shouldn't min dependency versions match? BuildRequires: php-composer(%{gh_owner}/zend-json) >= 2.6.1 # Require zend-json 3.0.0 as conflicts with previous Requires: php-composer(%{gh_owner}/zend-json) >= 3.0.0 In %check, `if which php71` but then `php70` usage. No blockers. ===== APPROVED ===== -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx