https://bugzilla.redhat.com/show_bug.cgi?id=1398949 --- Comment #1 from Jeremy Newton <alexjnewt@xxxxxxxxx> --- (In reply to MartinKG from comment #0) > Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/bear.spec > SRPM URL: > https://martinkg.fedorapeople.org/Review/SRPMS/bear-0.7.0-0.1gitac6be8b.fc25. > src.rpm > Description: Game engine and editors dedicated to creating great 2D games > Fedora Account System Username: martinkg > > %changelog > * Sun Nov 27 2016 Martin Gansser <martinkg@xxxxxxxxxxxxxxxxx> - > 0.7.0-0.1gitac6be8b > - imported package bear > > > rpmlint -i bear.spec > /home/martin/rpmbuild/SRPMS/bear-0.7.0-0.1gitac6be8b.fc25.src.rpm > /home/martin/rpmbuild/RPMS/x86_64/bear-engine-0.7.0-0.1gitac6be8b.fc25. > x86_64.rpm > /home/martin/rpmbuild/RPMS/x86_64/bear-factory-0.7.0-0.1gitac6be8b.fc25. > x86_64.rpm > /home/martin/rpmbuild/RPMS/x86_64/bear-debuginfo-0.7.0-0.1gitac6be8b.fc25. > x86_64.rpm > bear.src: W: spelling-error %description -l en_US plee -> peel, pee, lee > The value of this tag appears to be misspelled. Please double-check. > > bear.src: W: spelling-error %description -l en_US andy -> Andy, and, any > The value of this tag appears to be misspelled. Please double-check. > > bear-engine.x86_64: W: spelling-error Summary(en_US) Runtime -> Run time, > Run-time, Rudiment > The value of this tag appears to be misspelled. Please double-check. > > bear-engine.x86_64: W: spelling-error %description -l en_US plee -> peel, > pee, lee > The value of this tag appears to be misspelled. Please double-check. > > bear-engine.x86_64: W: spelling-error %description -l en_US andy -> Andy, > and, any > The value of this tag appears to be misspelled. Please double-check. > > bear-engine.x86_64: W: spelling-error %description -l en_US runtime -> run > time, run-time, rudiment > The value of this tag appears to be misspelled. Please double-check. > > bear-engine.x86_64: W: manual-page-warning > /usr/share/man/man6/running-bear.6.gz 5: warning: macro `RS' not defined > This man page may contain problems that can cause it not to be formatted as > intended. > > bear-engine.x86_64: W: manual-page-warning > /usr/share/man/man6/running-bear.6.gz 12: warning: macro `RE' not defined > This man page may contain problems that can cause it not to be formatted as > intended. > > bear-engine.x86_64: W: non-conffile-in-etc > /etc/ld.so.conf.d/bear-engine-x86_64.conf > A non-executable file in your package is being installed in /etc, but is not > a > configuration file. All non-executable files in /etc should be configuration > files. Mark the file as %config in the spec file. > > bear-factory.x86_64: W: manual-page-warning > /usr/share/man/man1/bf-animation-editor.1.gz 5: warning: macro `RS' not > defined > This man page may contain problems that can cause it not to be formatted as > intended. > > bear-factory.x86_64: W: manual-page-warning > /usr/share/man/man1/bf-animation-editor.1.gz 12: warning: macro `RE' not > defined > This man page may contain problems that can cause it not to be formatted as > intended. > > bear-factory.x86_64: W: manual-page-warning > /usr/share/man/man1/bf-level-editor.1.gz 5: warning: macro `RS' not defined > This man page may contain problems that can cause it not to be formatted as > intended. > > bear-factory.x86_64: W: manual-page-warning > /usr/share/man/man1/bf-level-editor.1.gz 12: warning: macro `RE' not defined > This man page may contain problems that can cause it not to be formatted as > intended. > > bear-factory.x86_64: W: manual-page-warning > /usr/share/man/man1/bf-model-editor.1.gz 5: warning: macro `RS' not defined > This man page may contain problems that can cause it not to be formatted as > intended. > > bear-factory.x86_64: W: manual-page-warning > /usr/share/man/man1/bf-model-editor.1.gz 12: warning: macro `RE' not defined > This man page may contain problems that can cause it not to be formatted as > intended. > > bear-factory.x86_64: W: non-conffile-in-etc > /etc/ld.so.conf.d/bear-factory-x86_64.conf > A non-executable file in your package is being installed in /etc, but is not > a > configuration file. All non-executable files in /etc should be configuration > files. Mark the file as %config in the spec file. > > bear-factory.x86_64: W: no-manual-page-for-binary image-cutter > Each executable in standard binary directories should have a man page. > > bear-factory.x86_64: W: no-manual-page-for-binary bend-image > Each executable in standard binary directories should have a man page. > > bear-factory.x86_64: W: desktopfile-without-binary > /usr/share/applications/desc2img.desktop desc2img > the .desktop file is for a file not present in the package. You should check > the requires or see if this is not a error > > 4 packages and 1 specfiles checked; 0 errors, 19 warnings. Some comments: - I would remove "Conflicts: wxGTK3-devel" - The sed commands can be compressed into: # change docbook_to_man to docbook2man sed -i -e 's|docbook-to-man|docbook2man|g' cmake-helper/docbook-to-man.cmake #sed -i -e 's|docbook-to-man|docbook-utils|' CMakeLists.txt sed -i -e 's|docbook-to-man|docbook2man|g' bear-*/desktop/man/*.sgml sed -i -e 's|docbook-to-man|docbook2man|g' bear-*/desktop/man/CMakeLists.txt - I would replace (non packaged) with (tunnel) from the descriptions, as this is the upstream git name and likely the future package name. - andy-super-great-park should be asgp (the upstream git name) - run-time is the correct spelling, not runtime - Add "%config" to fix the non-conffile-in-etc warnings - Is the desc2img binary missing? Or is this a typo in the .desktop? - I would think you should patch the man pages to fix the warnings, but I haven't looked into it -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx