https://bugzilla.redhat.com/show_bug.cgi?id=1398690 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@xxxxxxxxx --- Comment #1 from Fabio Valentini <decathorpe@xxxxxxxxx> --- ===================== | !! NON-BINDING !! | | Package Review | ===================== I did this preliminary package review as part of the process of becoming a fedora packager, so a "real" review is still needed. IMO, besides the unneccessary BuildRequires, the review looks simple enough. Regardless, a link to a successful koji scratch build would have been nice. Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: coreutils make findutils See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 Reviewer's Comment: The first 32 lines of the .spec file are not nicely formatted at all (indentation with 8-space-tabs instead of simple spaces, no empty lines for better readability, etc.) - although it seems that the .spec file has been adapted from another package or a Perl package template, because many already existing / approved perl package .specs look that way. ===== MUST items ===== Generic: [X]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [X]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. No licenses found. Please check the source files for licenses manually. [-]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [X]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/perl5/vendor_perl/Module/Extract(perl-Module-Extract- VERSION, perl-Module-Extract-Namespaces), /usr/share/perl5/vendor_perl/Module(perl-Module-Implementation, perl- Module-Runtime) [X]: Package contains no bundled libraries without FPC exception. [X]: Changelog in prescribed format. [X]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [?]: Package uses nothing in %doc for runtime. [X]: Package consistently uses macros (instead of hard-coded directory names). [X]: Package is named according to the Package Naming Guidelines. [X]: Package does not generate any conflict. [X]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [X]: Requires correct, justified where necessary. [X]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 3 files. [X]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [X]: Package contains the mandatory BuildRequires and Requires:. [X]: CPAN urls should be non-versioned. ===== SHOULD items ===== Generic: [?]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [X]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [X]: Latest version is packaged. [X]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [X]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: perl-Module-Extract-Use-1.04-2.fc26.noarch.rpm perl-Module-Extract-Use-1.04-2.fc26.src.rpm perl-Module-Extract-Use.noarch: W: spelling-error %description -l en_US eval -> veal, vela, val perl-Module-Extract-Use.noarch: W: spelling-error %description -l en_US pragmas -> pragmatism perl-Module-Extract-Use.src: W: spelling-error %description -l en_US eval -> veal, vela, val perl-Module-Extract-Use.src: W: spelling-error %description -l en_US pragmas -> pragmatism 2 packages and 0 specfiles checked; 0 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Requires -------- perl-Module-Extract-Use (rpmlib, GLIBC filtered): perl(:MODULE_COMPAT_5.24.0) perl(PPI) perl(strict) perl(subs) perl(vars) perl(warnings) Provides -------- perl-Module-Extract-Use: perl(Module::Extract::Use) perl-Module-Extract-Use Source checksums ---------------- http://search.cpan.org/CPAN/authors/id/B/BD/BDFOY/Module-Extract-Use-1.04.tar.gz : CHECKSUM(SHA256) this package : b2dba019d5dfde41217f10cfdc20ebd46c3deee00accef37097f1bf2597f5c9a CHECKSUM(SHA256) upstream package : b2dba019d5dfde41217f10cfdc20ebd46c3deee00accef37097f1bf2597f5c9a Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1398690 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Perl Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx