[Bug 1393796] Review Request: golang-github-go-errors-error - Package errors provides errors that have stack-traces

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1393796



--- Comment #4 from Gianluca Sforna <giallu@xxxxxxxxx> ---
(In reply to Dennis Chen from comment #3)
> Ok. We can get rid of the ExclusiveArch, 

the example mentions el6, but I am not sure it is limited to that. Without that
macro, we need keep track manually of which archs golang is available.

I think it would be wiser to keep it, but if you insist I will remove it.

> and then remove some unnecessary
> lines/comments:
> 
> %if 0%{?with_check} && ! 0%{?with_bundled}
> %endif

Done

> 
> %if 0%{?with_check}
> #Here comes all BuildRequires: PACKAGE the unit tests
> #in %%check section need for running
> %endif

Done

> 
> etc... And then I think we're good to go.

and done


See:
Spec URL: https://giallu.fedorapeople.org/golang-github-go-errors-errors.spec
SRPM URL:
https://giallu.fedorapeople.org/golang-github-go-errors-errors-0-0.3.gita418503.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]