[Bug 1379798] Review Request: pcsxr - A plugin based PlayStation (PSX) emulator with high compatibility

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1379798



--- Comment #20 from Jeremy Newton <alexjnewt@xxxxxxxxx> ---
(In reply to Epifanov Ivan from comment #19)
> BTW, are you sure that assert patch is (still) required?
> Removing this assert can lead to undefined behavior. The root problem of it,
> however, seems to be fixed long time ago.

Well IMHO, hard asserts should not be included in release code, so regardless
of it being fixed, it would be hidden behind a DEBUG flag. I can modify the
patch to throw a warning on stderr if you feel that would be more adequate. As
well, I have a few games I can confirm that throw this assert on boot, which
seems absolutely harmless to gameplay when ignored, yet will freeze on boot if
not ignored.

If this is fixed for these games in a future release, I will gladly remove this
patch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]