https://bugzilla.redhat.com/show_bug.cgi?id=1179350 Iryna Shcherbina <ishcherb@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mhroncok@xxxxxxxxxx --- Comment #5 from Iryna Shcherbina <ishcherb@xxxxxxxxxx> --- Hi Petr, I have reviewed the spec file and have a couple of items to point out: * The build fails with: RPM build errors: error: Installed (but unpackaged) file(s) found: /usr/lib/python3.5/site-packages/__pycache__/pytest_beakerlib.cpython-35.opt-1.pyc Installed (but unpackaged) file(s) found: /usr/lib/python3.5/site-packages/__pycache__/pytest_beakerlib.cpython-35.opt-1.pyc Please see Koji scratch build [0] for more details. * Smoke test is not being run: /var/tmp/rpm-tmp.Xy53Yw: line 33: smoketest.sh: command not found Besides, ${__python2} should probably be a macro in: PYTHON=${__python2} smoketest.sh PYTHON=${__python3} smoketest.sh * Please investigate the following error during byte compilation: + xargs -0 /usr/bin/python2 -O -c 'import py_compile, sys; [py_compile.compile(f, dfile=f.partition("$RPM_BUILD_ROOT")[2]], optimize=opt) for opt in range(2) for f in sys.argv[1:]]' find: '/builddir/build/BUILDROOT/python-pytest-beakerlib-0.5-2.fc24.x86_64/usr/lib/python2.7/site-packages/pytest-beakerlib': No such file or directory File "<string>", line 1 import py_compile, sys; [py_compile.compile(f, dfile=f.partition("$RPM_BUILD_ROOT")[2]], optimize=opt) for opt in range(2) for f in sys.argv[1:]] ^ SyntaxError: invalid syntax * There should be a python2-pytest-beakerlib subpackage which would provide python-pytest-beakerlib and python2-pytest-beakerlib. * The provided URL says that the project has moved to https://pagure.io/python-pytest-beakerlib, so you might consider using it instead. * Why would you have `Requires: python` and `Requires: python3` for the packages? * Please consider using %{summary} macro in the subpackage. [0] http://koji.fedoraproject.org/koji/taskinfo?taskID=16616285 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx