[Bug 1398340] Review Request: python-trezor - Python library for communicating with TREZOR Bitcoin Hardware Wallet

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1398340



--- Comment #4 from gil cattaneo <puntogil@xxxxxxxxx> ---
(In reply to gil cattaneo from comment #3)

> [!]: License field in the package spec file matches the actual license.
>      Note: Checking patched sources after %prep for licenses. Licenses
>      found: "BSD (3 clause)", "Unknown or generated". 52 files have unknown
>      license. Detailed output of licensecheck in /home/gil/1398340-python-
>      trezor/licensecheck.txt
> 
>   BSD (3 clause) trezor-0.7.7/trezorlib/protobuf_json.py
>   All source files are without license headers (the one exception to the
> above).
>   Please, ask to upstream to confirm the licensing of code and/or content/s,
> and add license headers
>  
> https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/
> LicensingGuidelines#License_Clarification
>      
> [?]: Package contains no bundled libraries without FPC exception.
> 
>   trezor-0.7.7/trezorlib/protobuf_json.py

    http://code.google.com/p/protobuf-json/

> [x]: Changelog in prescribed format.
> 
> [?]: Sources contain only permissible code or content.
> 
>   See above


> [!]: %check is present and all tests pass.
> 
>  Please, add a comment 

> [!]: Spec file according to URL is the same as in SRPM.
>      Note: Spec file as given by url is not the same as in SRPM (see
>      attached diff).
>      See: (this test has no URL)
> Diff spec file in url and in SRPM
> ---------------------------------
> --- /home/gil/1398340-python-trezor/srpm/python-trezor.spec	2016-11-25
> 00:24:18.767221286 +0100
> +++ /home/gil/1398340-python-trezor/srpm-unpacked/python-trezor.spec
> 2016-11-24 14:48:27.000000000 +0100
> @@ -57,3 +57,3 @@
>  
>  * Thu Nov 17 2016 Jonny Heggheim <jonnyheggheim@xxxxxxxxxxx> - 0.7.6-1
> -- initial package
> +- Initial package

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]