[Bug 1396817] Review Request: setlock - a go port of setlock ( an utility of daemontools)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1396817



--- Comment #3 from IWAI, Masaharu <iwaim.sub@xxxxxxxxx> ---
(In reply to Thomas Andrejak from comment #1)
> I'm not a packager yet, hence the review is unofficial.

Thanks for your review.

> - Summary:
> Start with an upcase

Fixed.

> - Patch0:
> Please add the URL to the upstream issue

It's my patch for creating RPM package.
So its upstream issue is nothing.


> - %files
> Why are you forcing defattr, it should be OK by default
> LICENSE is not a %doc but a %license

Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]