https://bugzilla.redhat.com/show_bug.cgi?id=1397842 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |panemade@xxxxxxxxx --- Comment #3 from Parag AN(पराग) <panemade@xxxxxxxxx> --- Few things I like to suggest here 1) I don't think you will need to have those top 2 python macros lines in the spec file. 2)those 3 comment lines in %install section 3)Good to more verbose in %files sections e.g. %files -n python2-cccolutils %license COPYING %{python2_sitearch}/tests %{python2_sitearch}/cccolutils.so %{python2_sitearch}/CCColUtils-1.1-py?.?.egg-info %if %{with python3} %files -n python3-cccolutils %license COPYING %{python3_sitearch}/tests %{python3_sitearch}/cccolutils.so %{python3_sitearch}/CCColUtils-1.1-py?.?.egg-info %endif # with python3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx