https://bugzilla.redhat.com/show_bug.cgi?id=1396232 --- Comment #2 from Phil Sutter <psutter@xxxxxxxxxx> --- Hi, (In reply to Igor Gnatenko from comment #1) > * CFLAGS/LDFLAGS are not used > export CFLAGS="%{optflags}" > export LDFLAGS="%{__global_ldflags}" > but it still requires some patching of Makefile `=` -> `?=` > * Missing BuildRequires: gcc > * You should try to version library (though I'm not sure how much it matters > here, probably doesn't at all) > * echo is not needed in %build > * instead of make you should use %make_build (e.g. %make_build -C src) > * there are some tests, so try to build / run them > * instead of doing mkdir, you can pass `-D` to install > > Apart from that, looks good ;) Thanks for the elaborate review! I'll try to get things sorted ASAP then upload fresh SRPM and spec file. Cheers, Phil -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx