https://bugzilla.redhat.com/show_bug.cgi?id=1382681 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags|fedora-review? |fedora-review+ --- Comment #8 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- naming: ok license: ok sources: ok (for now, 5.7.1 tarballs not officially released yet) macros: ok scriptlets: ok follows style/conventions of other qt5- packages Same comments as some other qt5- related reviews, 1. MUST reivew (and remove if needed) hard qt5 versioned dep, %{?_qt5:Requires: %{_qt5}%{?_isa} = %{_qt5_version}} 2. SHOULD remove BuildRequires: cmake it's not needed anymore, the appropriate cmake is pulled in by qt5-rpm-macros APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx