https://bugzilla.redhat.com/show_bug.cgi?id=1360255 --- Comment #16 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- naming: ok license: ok sources: ok (for now, 5.7.1 tarballs not officially released yet) macros: ok scriptlets: ok follows style/conventions of other qt5- packages 1. MUST review hard versioned dep: %{?_qt5:Requires: %{_qt5}%{?_isa} = %{_qt5_version}} Is this really needed (does it really used internal/private interfaces)? If so, MUST add (for tracking purposes): BuildRequires: qt5-qtbase-private-devel if not really needed, please remove it -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx