[Bug 1176273] Review Request: andy-super-great-park - 2D arcade game

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1176273



--- Comment #9 from Jeremy Newton <alexjnewt@xxxxxxxxx> ---
More notes:

Please make use of the make macros as well:

make %{?_smp_mflags}
->
%make_build

make install DESTDIR=%{buildroot} INSTALL="install -p"
->
%make_install

As well, please clean up %cmake, as some of the parameters are already defined
by this macro. Specifically, the following should be removed:
        -DCMAKE_VERBOSE_MAKEFILE=TRUE
        -DCMAKE_C_FLAGS="-DNDEBUG %{optflags}"
        -DCMAKE_CXX_FLAGS="-DNDEBUG %{optflags}"
        -DCMAKE_BUILD_WITH_INSTALL_RPATH=OFF
        -DCMAKE_INSTALL_PREFIX=%{_prefix}

Furthermore, I don't think these are necessary:
        -DCMAKE_NO_BUILTIN_CHRPATH=ON
        -DCMAKE_BUILD_WITH_INSTALL_RPATH=OFF
I think this is why you were having rpath issues, this should be ON not OFF:
        -DCMAKE_SKIP_RPATH:BOOL=OFF
You can replace it with a macro instead, for example:
%cmake . %_cmake_skip_rpath

Note that the oname variable can be effectively removed with updates I
suggested in comment#8.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]