https://bugzilla.redhat.com/show_bug.cgi?id=1389404 --- Comment #3 from Athos Ribeiro <athoscribeiro@xxxxxxxxx> --- Hi David, Naming: - All the Flask related packages are named with lower case. Did you consider that when naming this package? License: - The license file you are using belongs to the "Flask Sphinx Style" used in the documentation, not to this package. - Note that since this package is shipped under a BSD license, it must contain the full license text. The text is present in both files shipped in the package (__init__.py and wrappers.py), but it would be really nice if you considered asking upstream to also include the text in a separate file (like LICENSE or COPYING). This is not a blocker for this review, since the text is already available in the files I mentioned. Tests: - Upstream provides a test suite. Is there any reason for not running the tests in %check? Documentation: - There are some import errors being raised while building documentation, did you check that? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
