https://bugzilla.redhat.com/show_bug.cgi?id=1394952 Stephen Gallagher <sgallagh@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(mmathesi@redhat.c | |om) --- Comment #7 from Stephen Gallagher <sgallagh@xxxxxxxxxx> --- I have just a few remaining comments at this point: - Please put a space after %config(noreplace), for readability. It looks like part of the path, which it is not. - %config(noreplace)%{_sysconfdir}/avocado/conf.d/README, %config(noreplace) {_sysconfdir}/avocado/scripts/job/pre.d/README and %config(noreplace)%{_sysconfdir}/avocado/scripts/job/post.d/README should not be %config(noreplace). They shouldn't be edited by the end-user and as such we want changes to them clobbered on update. - Are %config(noreplace)%{_sysconfdir}/avocado/sysinfo/commands, %config(noreplace)%{_sysconfdir}/avocado/sysinfo/files and %config(noreplace)%{_sysconfdir}/avocado/sysinfo/profilers supposed to be editable by the end-user? If they're not *really* config files, they should not be %config(noreplace) (also, it would be best if upstream moved them to /usr/share if they're truly supposed to be immutable). - Please remove the executable bit from all python files in %doc. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx