[Bug 1365839] Review Request: python-django-notifications-hq - GitHub notifications alike app for Django

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1365839



--- Comment #5 from Julien Enselme <jujens@xxxxxxxxx> ---
- Can you launch the tests on python 3 too ? I also think that since you may
not be packaging python 2 depending on the system, you should guard the python
2 tests with the %if 0%{?with_python2} macros.
- The lists of requires are good. However, they are not in the proper package.
If you look at the output of fedora-review or rpm -qp --requires PACKAGE you
will see:
python2-django-notifications-hq (rpmlib, GLIBC filtered):
    python(abi)

python3-django-notifications-hq (rpmlib, GLIBC filtered):
    python(abi)

For them to be correct, you must declare them like this:
%if 0%{?with_python2}
%package -n python2-%{pypi_name}
Requires:  python2-django
Requires:  pytz
Requires:  python2-django-model-utils
Requires:  python2-django-jsonfield
Summary:        %{summary}
%{?python_provide:%python_provide python2-%{pypi_name}}

%description -n python2-%{pypi_name}
GitHub notification alike app for Django, derived from django-activity-stream.
%endif

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]