[Bug 1396922] Review Request: python-yarl - A Python module to handle URLs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1396922

Igor Gnatenko <ignatenko@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?



--- Comment #1 from Igor Gnatenko <ignatenko@xxxxxxxxxx> ---
* No need for "A" in summary, it's making it more unreadable
* It's better to take archive out of GitHub, not from PyPI (especially when it
comes down to Cython, why checks if it uses Cython to generate code or uses
pre-generated code)
* python3-yarl.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python3.5/site-packages/yarl/_quoting.c -> please report bug to
upstream and make note in spec
* Tests are not executed, but present
* %{python3_sitearch}/%{srcname}*.egg-info ->
%{python3_sitearch}/%{srcname}-*.egg-info/ (trailing slash is needed for RPM to
not accept files, disutils uses file, setuptools uses directory)

ALMOST GOOD.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]