https://bugzilla.redhat.com/show_bug.cgi?id=1396216 --- Comment #2 from gil cattaneo <puntogil@xxxxxxxxx> --- (In reply to Thomas Andrejak from comment #1) > I'm not a packager yet, hence the review is unofficial. > > - Be carefull with 80 columns, even in comments, but when you have space > (%description), use it ? i dont care about this ... > - On my side, http://wiki.fasterxml.com/AaltoHome is not working At the moment fasterxml site is offline > - In %description javadoc, use a more interesting description (We already > now that this is a package, and this is the javadoc) or use the same > description as the main package For me is fine so ... > - Why are you doing this : > mv release-notes/asl/ASL2.0 LICENSE > mv release-notes/asl/LICENSE NOTICE > > in %files you can use %licence with path No, thanks > - %files javadoc : %license is only required in main package NOT true Before add others comment, please, read our Java packaging guideline/s, and are available here https://fedora-java.github.io/howto/latest/ https://fedoraproject.org/wiki/Packaging:Java Thanks and regards > Regards -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx