https://bugzilla.redhat.com/show_bug.cgi?id=1396819 Thomas Andrejak <thomas.andrejak@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thomas.andrejak@xxxxxxxxx --- Comment #3 from Thomas Andrejak <thomas.andrejak@xxxxxxxxx> --- I'm not a packager yet, hence the review is unofficial. - Patchs https://fedoraproject.org/wiki/Packaging:Guidelines#Patch_Guidelines Patch01 -> Patch1 0001.... -> remove 0001, etc 0002-build-sys-create-all-destination-directories-and-do-.patch -> why an ending - ? For each patch, please add the issue URL to upstream - %description devel The %{name}-devel package contains header files for developing applications that use %{name}. => Header files for developing applications that use %{name} - %build Why are you forcing cflags instead of making patchs ? - %check %ifarch aarch64 ./test.sh || : %else ./test.sh || : %endif => why this "if" with same inside block ? - %license Have you forgotten COPYING.bsd ? - %doc %{_mandir}/man3/kcapi_*.3* => man pages are not %doc -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx