https://bugzilla.redhat.com/show_bug.cgi?id=1375380 Till Maas <opensource@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |opensource@xxxxxxxxx --- Comment #1 from Till Maas <opensource@xxxxxxxxx> --- It is awesome, that you want to package this. Unfortunately I have found some issues at first glance: - The README file contains mostly the license, therefore IMHO it should be included with %license. - Have you considered shipping the examples and doc dirs as %doc? - iceboxdb.py seems to be a module and not a program, therefore it does not belong to /usr/bin but rather %python_sitelib I think. It might be a good idea to discuss the proper path with upstream. For future-proofness it might be a good idea to put it in a directory in %python_sitelib such as icebox and put it in a db.py file there. Having it in /usr/bin also creates the problem that it might create .pyc/.pyo files there, since iceboxdb.py is imported - Also the files in /usr/bin should not have a .py suffix -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx