https://bugzilla.redhat.com/show_bug.cgi?id=1396513 --- Comment #2 from Vitaly Zaitsev <vitaly@xxxxxxxxxxxxxx> --- ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. OK. [ ]: Package contains no static executables. OK. [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. OK. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "BSD (3 clause)", "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or generated". 31 files have unknown license. Detailed output of licensecheck in /home/vitaly/1396513-nitrokey- app/licensecheck.txt Apache (v2.0) ------------- nitrokey-app-0.5.1/src/utils/base32.cpp nitrokey-app-0.5.1/src/utils/base32.h BSD (3 clause) -------------- nitrokey-app-0.5.1/src/inttypes.h GPL (v2 or later) ----------------- nitrokey-app-0.5.1/src/ui/splash.cpp nitrokey-app-0.5.1/src/ui/splash.h nitrokey-app-0.5.1/src/utils/gui.cpp nitrokey-app-0.5.1/src/utils/gui.h GPL (v3 or later) ----------------- All others. [ ]: License file installed when any subpackage combination is installed. OK. [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/udev, /usr/share/icons/hicolor/22x22, /usr/share/icons/hicolor/22x22/apps, /usr/share/icons/hicolor/24x24/apps, /usr/share/icons/hicolor/24x24, /usr/lib/udev/rules.d, /usr/share/icons/hicolor/scalable/apps, /usr/share/icons/hicolor/scalable Add hicolor-icon-theme and systemd-udev to Requires of package. [ ]: %build honors applicable compiler flags or justifies otherwise. OK. [ ]: Package contains no bundled libraries without FPC exception. OK. [ ]: Changelog in prescribed format. OK. [ ]: Sources contain only permissible code or content. OK. [ ]: Development files must be in a -devel package OK. [ ]: Package uses nothing in %doc for runtime. OK. [ ]: The spec file handles locales properly. OK. [ ]: Package consistently uses macros (instead of hard-coded directory names). OK. [ ]: Package is named according to the Package Naming Guidelines. OK. [ ]: Package does not generate any conflict. OK. [ ]: Package obeys FHS, except libexecdir and /usr/target. OK. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. OK. [ ]: Requires correct, justified where necessary. Add hicolor-icon-theme and systemd-udev to Requires of package. [ ]: Spec file is legible and written in American English. OK. [ ]: Package contains systemd file(s) if in need. OK. [ ]: gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. OK.. [ ]: Useful -debuginfo package or justification otherwise. OK. [ ]: Package is not known to require an ExcludeArch tag. OK. [ ]: Package complies to the Packaging Guidelines OK. ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. OK. [ ]: Final provides and requires are sane (see attachments). OK. [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in nitrokey-app-debuginfo OK. [ ]: Package functions as described. OK. [ ]: Latest version is packaged. OK. [ ]: Package does not include license text files separate from upstream. OK. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. OK. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. OK. [ ]: Package should compile and build into binary rpms on all supported architectures. OK. [ ]: %check is present and all tests pass. OK. [ ]: Packages should try to preserve timestamps of original installed files. OK. [x]: Reviewer should test that the package builds in mock. Tested. Works. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx