https://bugzilla.redhat.com/show_bug.cgi?id=1155793 Ben Rosser <rosser.bjr@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|i@xxxxxxxx |rosser.bjr@xxxxxxxxx Flags|needinfo?(i@xxxxxxxx) | --- Comment #25 from Ben Rosser <rosser.bjr@xxxxxxxxx> --- Taken this review. I ran through the spec and only found one issue: there are bundled copies of mtrand and glew in the sources; from licensecheck: BSD (2 clause) -------------- hyperrogue-83j/src/glew.c hyperrogue-83j/src/mtrand.h It doesn't seem like glew.c is used in the Linux build. If that's the case you should probably explicitly remove it in %prep (so this can be verified), although this isn't a requirement. But mtrand definitely seems to be, which means you should modify the License tag accordingly to reflect that (License: GPLv2 and BSD) and explain why in a comment. As per https://fedoraproject.org/wiki/Packaging:Guidelines#Bundling_and_Duplication_of_system_libraries you should probably also add a "Provides: bundled(mtrand)" to the spec. Otherwise the package looks good. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx