https://bugzilla.redhat.com/show_bug.cgi?id=1390595 Piotr Popieluch <piotr1212@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |piotr1212@xxxxxxxxx --- Comment #1 from Piotr Popieluch <piotr1212@xxxxxxxxx> --- I'm interested in having librdkafka in Fedora and EPEL. I'm no sponsor so I can't sponsor you, but I can help you with this package. When doing a review, the reviewers use fedora-review -b which automates some tasks. F-R downloads the files from the urls in the bugreport, builds the packge and runs some tests. Please make sure "fedora-review -b 1390595" builds correctly. rpmlint might be helpful too. To become sponsored, you will have to do a couple unofficial reviews to show you understand the package guidelines [1]. You can post the urls to those reviews here. Some comments: version/release needs to be defined in the uploaded specfile. Group tag is deprecated, remove it unless you still want to support EL5 (which will EOL soon). License tag must match the short license as listed in [2] Source needs to specify the upstream source url. [3] BuildRoot tag is deprecated (unless EL5 support) description needs to be wrapped at 80 chars requires for rhel >=7 is openssl-libs, I would expect this to be the same for Fedora (didn't check) %clean is deprecated don't rm -rf %{buildroot} in %install %build you will probably want to define CFLAGS='%{optflags} to have all default options and hardening. %doc, put license files in %license, not %doc. Why is the permission set to 444 in %files? [1] https://fedoraproject.org/wiki/Packaging:Guidelines [2] https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses [3] https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx