https://bugzilla.redhat.com/show_bug.cgi?id=1394962 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #14 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. GPLv3+ [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "GPL (v3 or later)", "Unknown or generated". 9 files have unknown license. Detailed output of licensecheck in /var/tmp/1394962-clevis/licensecheck.txt [x]: License file installed when any subpackage combination is installed. Yes, all packages transitively depend on clevis.rpm which has the license. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/dracut/modules.d/60clevis [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/dracut/modules.d/60clevis Please add %dir /usr/lib/dracut/modules.d/60clevis to %files. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Package uses hardened build flags if required to. Note: suid files: clevis-luks-udisks2 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: Package contains systemd file(s) if in need. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in clevis- dracut , clevis-udisks2 , clevis-debuginfo clevis-dracut -> clevis-luks -> clevis clevis-udisks2 -> clevis-luks -> clevis [-]: Package functions as described. Not checked. I don't have a server set up that clevis could talk to. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: clevis-2-1.fc26.x86_64.rpm clevis-luks-2-1.fc26.x86_64.rpm clevis-dracut-2-1.fc26.x86_64.rpm clevis-udisks2-2-1.fc26.x86_64.rpm clevis-debuginfo-2-1.fc26.x86_64.rpm clevis-2-1.fc26.src.rpm clevis.x86_64: W: spelling-error %description -l en_US luks -> looks, lurks, lucks clevis.x86_64: W: spelling-error %description -l en_US dracut -> Dracula clevis.x86_64: W: no-documentation clevis-luks.x86_64: W: spelling-error %description -l en_US unlocker -> unlocked, unlock er, unlock-er clevis-luks.x86_64: W: spelling-error %description -l en_US dracut -> Dracula clevis-luks.x86_64: W: no-documentation clevis-dracut.x86_64: W: only-non-binary-in-usr-lib clevis-dracut.x86_64: W: no-documentation clevis-udisks2.x86_64: W: spelling-error %description -l en_US storaged -> storage, storage d, stored clevis-udisks2.x86_64: W: no-documentation clevis.src: W: spelling-error %description -l en_US luks -> looks, lurks, lucks All OK. clevis.x86_64: W: no-manual-page-for-binary clevis More docs would be nice ;) clevis-udisks2.x86_64: E: setuid-binary /usr/libexec/clevis-luks-udisks2 root 4755 clevis-udisks2.x86_64: E: non-standard-executable-perm /usr/libexec/clevis-luks-udisks2 4755 OK. clevis-udisks2.x86_64: W: non-conffile-in-etc /etc/xdg/autostart/clevis-luks-udisks2.desktop Despite the location, this is not a config file. Not using %config matches what other packages which install files there are doing. Somebody should move the whole lot to /usr. clevis.src:90: E: hardcoded-library-path in %{_prefix}/lib/dracut/modules.d/60%{name}/module-setup.sh clevis.src:91: E: hardcoded-library-path in %{_prefix}/lib/dracut/modules.d/60%{name}/%{name}-hook.sh That's OK too, I think. 6 packages and 0 specfiles checked; 4 errors, 13 warnings. Rpmlint (debuginfo) ------------------- Checking: clevis-debuginfo-2-1.fc26.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Requires -------- clevis-debuginfo (rpmlib, GLIBC filtered): clevis-udisks2 (rpmlib, GLIBC filtered): clevis-luks(x86-64) libc.so.6()(64bit) libcryptsetup.so.4()(64bit) libcryptsetup.so.4(CRYPTSETUP_1.0)(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libhttp_parser.so.2()(64bit) libluksmeta.so.0()(64bit) libpthread.so.0()(64bit) libudisks2.so.0()(64bit) rtld(GNU_HASH) clevis-luks (rpmlib, GLIBC filtered): /bin/bash clevis(x86-64) cryptsetup luksmeta clevis (rpmlib, GLIBC filtered): /bin/bash coreutils libc.so.6()(64bit) libcrypto.so.1.1()(64bit) libcrypto.so.1.1(OPENSSL_1_1_0)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libhttp_parser.so.2()(64bit) libjansson.so.4()(64bit) libjose-openssl.so.0()(64bit) libjose-zlib.so.0()(64bit) libjose.so.0()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) clevis-dracut (rpmlib, GLIBC filtered): /bin/bash clevis-luks(x86-64) dracut-network nc Provides -------- clevis-debuginfo: clevis-debuginfo clevis-debuginfo(x86-64) clevis-udisks2: clevis-udisks2 clevis-udisks2(x86-64) clevis-luks: clevis-luks clevis-luks(x86-64) clevis: clevis clevis(x86-64) clevis-dracut: clevis-dracut clevis-dracut(x86-64) Package is APPROVED. Please fix the directory ownership issue when uploading. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx