https://bugzilla.redhat.com/show_bug.cgi?id=1395804 --- Comment #2 from Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> --- Thanks for your feedback. (In reply to Iryna Shcherbina from comment #1) > * there is a new version of the package 0.4.2, which was released just > yesterday Yes, I know. I worked with upstream to get a couple of issues sorted out. Shebang, license, and typos. > * with the new release the license file is included in the tar, so please > include it in %license That was one issue. > * please use %{srcname} macro in the URL No, this adds no real value and make the URL very copy-&-paste unfriendly in the spec file. I know that this is shown in the guidelines. If the project is renamed or the orga changed then the URL needs to be modified anyways. Updated files: Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-batinfo.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-batinfo-0.4.2-1.fc24.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx