[Bug 1396139] Review Request: libmad - MPEG audio decoder library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1396139



--- Comment #4 from Nicolas Chauvet (kwizart) <kwizart@xxxxxxxxx> ---
(In reply to Igor Gnatenko from comment #3)
> %if 0%{__isa_bits} == 64 or smth like this..
It's already using that, but the Neal concern is that 64Bit would be Intel
specific.

@Neal
Looking at the code, I don't read that, looking at line 132 in fixed.h define a
non asm version of mad_f_mul. Also it's mentioned that the 64Bit FPM should
work as soon a a compiler has 64bit type. But my understanding is that it will
not perform better if not a native 64bit arch.
So using FPM=64bit seems a safe improvement over using ASM specific code on
64bit arches.

That been said, FPM=Intel is indeed x86 asm specific. I've never tested that
option.

For arm, it's defined in line 253 and is asm specific. It's also advertised as
performing better than FPM=64bit. I've only selected that option because it was
worked on recently (on the referenced bug) and I've made a runtime test that it
worked fine at the time I've bootstrapped RPM Fusion for arm. (was armv5tel and
armv7hl at that time).

Fixed the others issues locally.

@Neal, any comment on the FPM option ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]