https://bugzilla.redhat.com/show_bug.cgi?id=1290342 Nicolas Chauvet (kwizart) <kwizart@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(kwizart@xxxxxxxxx | |) | --- Comment #13 from Nicolas Chauvet (kwizart) <kwizart@xxxxxxxxx> --- (In reply to gil cattaneo from comment #10) > > - You are missing a "-" between email and package EVR in changelog. rpmlint > > haven't found it and I don't expect it's a hard requirement. But at least > > that the format used by the rpmdev-bumpspec tool > > I dont want use "-" in my spec file, and i am not interested to use that tool It's a weird answer. I wouldn't have expected it. The problem is that other maintainers and provenpackager will use theses tools, or even use parser that may break if the "-" isn't found. Above all it's improving readability. > > - What the point to use /usr/bin/perl over perl (as package) directly ? or > > at least the appropriate macro ? > > I need only the binary for change the build scripts ... okay, but %{_bindir} should be used here why not using the macro ? Also I don't think perl packaging will change it's packaging scheme not to have the perl binary in the main perl package. That been said, I would use sed (that is in the default buildroot) instead to avoid a dependency on perl (that is no more in the default buildroot). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx