[Bug 1396139] Review Request: libmad - MPEG audio decoder library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1396139



--- Comment #2 from Neal Gompa <ngompa13@xxxxxxxxx> ---
A few notes of things that should be fixed:

* Please don't explicitly require "pkgconfig" in the devel subpackage.
"/usr/bin/pkg-config" gets added as a dependency anyway, so it's redundant.

* On your autoreconf command, please add "-v", as we want the output to be
captured in build logs.

* The conditional for "--enable-fpm=64bit" looks like it should be "%ifarch
x86_64", as it looks like 64bit is specifically talking about 64-bit x86. Thus,
the current isa bits conditional is likely wrong.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]