https://bugzilla.redhat.com/show_bug.cgi?id=1028743 --- Comment #5 from Michal Ambroz <rebus@xxxxxxxxx> --- Hello Pavel, thaks for packaging hans. As Christopher Meng doesn't seem to be responding I would like to take over the package review. I have found the spec and sources on github, but the spec and srpm is not available for download anymore. Claimed links do not download the files. Generally package sees good to me and - just few coments: - update to 0.4.4 - I would recommend to change the source reference to https://github.com/friedrich/%{name}/archive/v%{version}.tar.gz#/hans-%{version}.tar.gz so the source file is named hans-%{version}.tar.gz - rpmlint reports that there is missing-call-to-setgroups-before-setuid Will be fixed by this patch (https://github.com/friedrich/hans/issues/15) - I would say it is dangerous having working default configuration. I would recommend generating random password with first use - something like server key for the ssh. - fix typos sulution->solution, dinamic->dynamic (hans-client.sysconfig) Other issues from rpmlint seems to be minors. $ rpmlint SRPMS/hans-0.4.4-1.fc24.src.rpm RPMS/x86_64/hans-0.4.4-1.fc24.x86_64.rpm RPMS/x86_64/hans-client-0.4.4-1.fc24.x86_64.rpm RPMS/x86_64/hans-server-0.4.4-1.fc24.x86_64.rpm RPMS/x86_64/hans-debuginfo-0.4.4-1.fc24.x86_64.rpm hans.src: W: spelling-error %description -l en_US firewalled -> fire walled, fire-walled, firewall ed hans.x86_64: W: spelling-error %description -l en_US firewalled -> fire walled, fire-walled, firewall ed hans.x86_64: E: missing-call-to-setgroups-before-setuid /usr/sbin/hans hans.x86_64: W: no-manual-page-for-binary hans hans-client.x86_64: W: spelling-error %description -l en_US sulution -> solution, insulation, ululation hans-client.x86_64: W: no-documentation hans-client.x86_64: W: non-standard-uid /etc/sysconfig/hans-client hans hans-client.x86_64: E: non-readable /etc/sysconfig/hans-client 600 hans-server.x86_64: W: no-documentation hans-server.x86_64: W: non-standard-uid /etc/sysconfig/hans-server hans hans-server.x86_64: E: non-readable /etc/sysconfig/hans-server 600 5 packages and 0 specfiles checked; 3 errors, 10 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx