https://bugzilla.redhat.com/show_bug.cgi?id=1394952 Stephen Gallagher <sgallagh@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mmathesi@xxxxxxxxxx Flags| |needinfo?(mmathesi@redhat.c | |om) --- Comment #5 from Stephen Gallagher <sgallagh@xxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== Issues ===== * License: field only describes GPLv2, but the licensecheck shows MIT license as well. Please also check whether GPLv2 or GPLv2+ is correct. * Requires for the main package should be for python2-%{srcname}, not python-%{srcname} * Requires for subpackages on the main package must be fully versioned. e.g.: Requires: python2-%{srcname} == %{version}-%{release} This is to ensure that if a user runs `dnf update python2-avocado`, they are guaranteed to get the subpackage built together with it. If there is a special reason this should not happen, it needs to be in a comment in the spec file. * Package uses but does not own /usr/share/avocado, /usr/share/doc/avocado, /etc/avocado/scripts/job, /etc/avocado/scripts, /usr/libexec/avocado * The BuildRequires should use the python2-foo variant of the Requires, since the package does not support python3. The unversioned python-foo Requires is now reserved for packages that can switch between them (so that in the future the %{python_provides} macro will change which version supplies the unversioned name. * The python2-avocado-plugins-output-html subpackage bundles a font, glyphicons-halflings-regular. This does not appear to be actually freely licensed for use in Fedora. Glyphicons.com appears to charge for this font, though it is available "for free" (no license specified) if installed through bootstrap (which this package does not use). See http://getbootstrap.com/components/#glyphicons for the line "Glyphicons Halflings are normally not available for free, but their creator has made them available for Bootstrap free of cost. Unfortunately, "free of cost" is not the same thing as "freely distributable". This needs to be discussed with upstream urgently. * The python-avocado-examples subpackage needs to put all of its contents into the %{_docdir} hierarchy rather than %{python2_sitelib}. They are not runtime contents. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL", "GPL (v2 or later)", "Unknown or generated", "*No copyright* GPL", "MIT/X11 (BSD like)", "*No copyright* GPL (v2 or later)", "GPL (v2)". 253 files have unknown license. Detailed output of licensecheck in /home/sgallagh/1394952-python- avocado/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/avocado, /usr/share/doc/avocado, /etc/avocado/scripts/job, /etc/avocado/scripts, /usr/libexec/avocado [!]: Package must own all directories that it creates. Note: Directories without known owners: /etc/avocado/scripts/job, /etc/avocado/scripts, /usr/share/doc/avocado, /usr/libexec/avocado, /usr/share/avocado [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 3 files. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [X]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2-avocado , python2-avocado-plugins-output-html , python- avocado-examples [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-avocado-43.0-4.fc26.noarch.rpm python2-avocado-plugins-output-html-43.0-4.fc26.noarch.rpm python-avocado-examples-43.0-4.fc26.noarch.rpm python-avocado-43.0-4.fc26.src.rpm python2-avocado-plugins-output-html.noarch: W: spelling-error %description -l en_US filesystem -> file system, file-system, systemically python2-avocado-plugins-output-html.noarch: W: no-documentation python-avocado-examples.noarch: W: no-documentation python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/datadir.py /usr/bin/env python python-avocado-examples.noarch: E: non-executable-script /usr/share/avocado/tests/datadir.py 644 /usr/bin/env python python-avocado-examples.noarch: W: devel-file-in-non-devel-package /usr/share/avocado/tests/gdbtest.py.data/return99.c python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/errortest.py /usr/bin/env python python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/cabort.py /usr/bin/env python python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/passtest.py /usr/bin/env python python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/raise.py /usr/bin/env python python-avocado-examples.noarch: W: devel-file-in-non-devel-package /usr/share/avocado/tests/datadir.py.data/datadir.c python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/sleeptest.py /usr/bin/env python python-avocado-examples.noarch: W: devel-file-in-non-devel-package /usr/share/avocado/tests/doublefree_nasty.py.data/doublefree.c python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/gdbtest.py /usr/bin/env python python-avocado-examples.noarch: W: devel-file-in-non-devel-package /usr/share/avocado/tests/gdbtest.py.data/segfault.c python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/doublefree_nasty.py /usr/bin/env python python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/multiple_tests.py /usr/bin/env python python-avocado-examples.noarch: E: non-executable-script /usr/share/avocado/tests/multiple_tests.py 644 /usr/bin/env python python-avocado-examples.noarch: W: devel-file-in-non-devel-package /usr/share/avocado/tests/raise.py.data/raise.c python-avocado-examples.noarch: E: zero-length /usr/share/avocado/tests/output_check.sh.data/stderr.expected python-avocado-examples.noarch: W: devel-file-in-non-devel-package /usr/share/avocado/tests/doublefree.py.data/doublefree.c python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/doublefree.py /usr/bin/env python python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/modify_variable.py /usr/bin/env python python-avocado-examples.noarch: W: devel-file-in-non-devel-package /usr/share/avocado/tests/modify_variable.py.data/print_variable.c python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/fail_on_exception.py /usr/bin/env python python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/errortest_nasty2.py /usr/bin/env python python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/multiplextest.py /usr/bin/env python python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/skip_outside_setup.py /usr/bin/env python python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/sleeptenmin.py /usr/bin/env python python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/gendata.py /usr/bin/env python python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/skiponsetup.py /usr/bin/env python python-avocado-examples.noarch: E: non-executable-script /usr/share/avocado/tests/skiponsetup.py 644 /usr/bin/env python python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/errortest_nasty3.py /usr/bin/env python python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/synctest.py /usr/bin/env python python-avocado-examples.noarch: W: devel-file-in-non-devel-package /usr/share/avocado/tests/cabort.py.data/abort.c python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/whiteboard.py /usr/bin/env python python-avocado-examples.noarch: E: zero-length /usr/share/avocado/tests/synctest.py.data/stderr.expected python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/linuxbuild.py /usr/bin/env python python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/failtest.py /usr/bin/env python python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/timeouttest.py /usr/bin/env python python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/abort.py /usr/bin/env python python-avocado-examples.noarch: E: non-executable-script /usr/share/avocado/tests/abort.py 644 /usr/bin/env python python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/warntest.py /usr/bin/env python python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/trinity.py /usr/bin/env python python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/uncaught_exception.py /usr/bin/env python python-avocado-examples.noarch: E: non-executable-script /usr/share/avocado/tests/uncaught_exception.py 644 /usr/bin/env python python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/doublefail.py /usr/bin/env python python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/errortest_nasty.py /usr/bin/env python 4 packages and 0 specfiles checked; 37 errors, 11 warnings. Rpmlint (installed packages) ---------------------------- python2-avocado-plugins-output-html.noarch: W: spelling-error %description -l en_US filesystem -> file system, file-system, systemically python2-avocado-plugins-output-html.noarch: W: no-documentation python-avocado-examples.noarch: W: no-documentation python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/sleeptenmin.py /usr/bin/env python python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/synctest.py /usr/bin/env python python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/abort.py /usr/bin/env python python-avocado-examples.noarch: E: non-executable-script /usr/share/avocado/tests/abort.py 644 /usr/bin/env python python-avocado-examples.noarch: W: devel-file-in-non-devel-package /usr/share/avocado/tests/gdbtest.py.data/segfault.c python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/errortest_nasty3.py /usr/bin/env python python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/gdbtest.py /usr/bin/env python python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/errortest_nasty.py /usr/bin/env python python-avocado-examples.noarch: E: zero-length /usr/share/avocado/tests/synctest.py.data/stderr.expected python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/cabort.py /usr/bin/env python python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/errortest_nasty2.py /usr/bin/env python python-avocado-examples.noarch: W: devel-file-in-non-devel-package /usr/share/avocado/tests/doublefree_nasty.py.data/doublefree.c python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/skip_outside_setup.py /usr/bin/env python python-avocado-examples.noarch: W: devel-file-in-non-devel-package /usr/share/avocado/tests/raise.py.data/raise.c python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/whiteboard.py /usr/bin/env python python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/passtest.py /usr/bin/env python python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/errortest.py /usr/bin/env python python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/fail_on_exception.py /usr/bin/env python python-avocado-examples.noarch: W: devel-file-in-non-devel-package /usr/share/avocado/tests/modify_variable.py.data/print_variable.c python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/modify_variable.py /usr/bin/env python python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/gendata.py /usr/bin/env python python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/multiple_tests.py /usr/bin/env python python-avocado-examples.noarch: E: non-executable-script /usr/share/avocado/tests/multiple_tests.py 644 /usr/bin/env python python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/trinity.py /usr/bin/env python python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/datadir.py /usr/bin/env python python-avocado-examples.noarch: E: non-executable-script /usr/share/avocado/tests/datadir.py 644 /usr/bin/env python python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/doublefree_nasty.py /usr/bin/env python python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/timeouttest.py /usr/bin/env python python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/warntest.py /usr/bin/env python python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/failtest.py /usr/bin/env python python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/uncaught_exception.py /usr/bin/env python python-avocado-examples.noarch: E: non-executable-script /usr/share/avocado/tests/uncaught_exception.py 644 /usr/bin/env python python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/doublefree.py /usr/bin/env python python-avocado-examples.noarch: W: devel-file-in-non-devel-package /usr/share/avocado/tests/doublefree.py.data/doublefree.c python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/skiponsetup.py /usr/bin/env python python-avocado-examples.noarch: E: non-executable-script /usr/share/avocado/tests/skiponsetup.py 644 /usr/bin/env python python-avocado-examples.noarch: E: zero-length /usr/share/avocado/tests/output_check.sh.data/stderr.expected python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/doublefail.py /usr/bin/env python python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/multiplextest.py /usr/bin/env python python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/raise.py /usr/bin/env python python-avocado-examples.noarch: W: devel-file-in-non-devel-package /usr/share/avocado/tests/datadir.py.data/datadir.c python-avocado-examples.noarch: W: devel-file-in-non-devel-package /usr/share/avocado/tests/cabort.py.data/abort.c python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/linuxbuild.py /usr/bin/env python python-avocado-examples.noarch: E: wrong-script-interpreter /usr/share/avocado/tests/sleeptest.py /usr/bin/env python python-avocado-examples.noarch: W: devel-file-in-non-devel-package /usr/share/avocado/tests/gdbtest.py.data/return99.c 3 packages and 0 specfiles checked; 37 errors, 11 warnings. Requires -------- python2-avocado-plugins-output-html (rpmlib, GLIBC filtered): pystache python(abi) python2-avocado python-avocado-examples (rpmlib, GLIBC filtered): /bin/bash /bin/sh /usr/bin/env python-avocado python2-avocado (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python2 config(python2-avocado) fabric gdb gdb-gdbserver libvirt-python procps-ng pyliblzma pystache python python(abi) python-aexpect python-requests python-stevedore python-yaml Provides -------- python2-avocado-plugins-output-html: python-avocado-plugins-output-html python2-avocado-plugins-output-html python2.7dist(avocado-result-html) python2dist(avocado-result-html) python-avocado-examples: python-avocado-examples python2-avocado-examples python2-avocado: config(python2-avocado) python-avocado python2-avocado python2.7dist(avocado-framework) python2dist(avocado-framework) Source checksums ---------------- https://github.com/avocado-framework/avocado/archive/43.0.tar.gz#/avocado-43.0.tar.gz : CHECKSUM(SHA256) this package : 9c0bf4742968c1b67399ce79ca8d1efd422769220530614cf381866bbd51bc22 CHECKSUM(SHA256) upstream package : 9c0bf4742968c1b67399ce79ca8d1efd422769220530614cf381866bbd51bc22 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1394952 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx