[Bug 1395955] Review Request: fatresize - FAT16/FAT32 resizer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1395955



--- Comment #3 from Neal Gompa <ngompa13@xxxxxxxxx> ---
Going point by point:

> Release:        1.git20100729

Please add %{?dist} at the end. See
https://fedoraproject.org/wiki/Packaging:DistTag for more information.

> Group:          File tools

Mandrake RPM groups (used by Mandrake and its derivatives, such as Mageia and
ALT Linux) are not permitted. Either select the appropriate Red Hat RPM
group[1] or remove the Group tag entirely, as it is optional in Fedora unless
you intend to make this available for CentOS/RHEL 5 via EPEL.

[1]: https://fedoraproject.org/wiki/RPMGroups

> autoreconf -if

Please use "autoreconf -fiv", as we want the output to be seen in the logs.

> make

Unless it breaks with it, please use "%make_build" for parallel make

> %_sbindir/*
> %_mandir/man1/*

Please use %{_sbindir} and %{_mandir} instead of %_sbindir and %_mandir.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]