https://bugzilla.redhat.com/show_bug.cgi?id=1395554 --- Comment #1 from Athos Ribeiro <athoscribeiro@xxxxxxxxx> --- As specified in [1], ASL 2.0 requires the license text to be distributed with the binaries/sources. In this case, you should ask upstream to include the full license text in the package. Note that in this case, this is a blocker for this review. Is there any reason for using "%bcond_with tests" and not running the %check section by default? Finally, there is a notes.txt file in the sources, saying "Written Consent from Google has been obtained by following the steps outlined at the following location"... [2]. What is this about? In the README file there is a note, saying: "Access to the `GoogleGeocoder` requires you to agree to be bound by Google Maps/Google Earth APIs Terms of Service found at https://developers.google.com/maps/terms which includes but is not limited to having a Google Account." When the author says `GoogleGeocoder`, is he referring to the class GoogleGeocoder inside this package or to the google service it accesses? Of course the former makes less/no sense, but that's something I kept asking myself when I read that. [1] https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text [2] http://support.google.com/maps/bin/static.py?hl=en&ts=1342531&page=ts.cs -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx