https://bugzilla.redhat.com/show_bug.cgi?id=1386774 Randy Barlow <randy@xxxxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rdieter@xxxxxxxxxxxx Flags| |needinfo?(rdieter@xxxxxxxx. | |edu) --- Comment #3 from Randy Barlow <randy@xxxxxxxxxxxxxxxxxxxxx> --- There are a few things in the MUST section that we will need to fix. I've added "randy: " comments to expand on the !'s a bit. All of my comments outside of the MUST section are just recommendations, so you can feel free to ignore those if you disagree. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. randy: It looks like the %license macro is commented out in the %files section. It could/should also be added to the devel subpackage. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "*No copyright* BSD (3 clause)", "MIT/X11 (BSD like)", "GPL (v2 or later)", "Unknown or generated". 105 files have unknown license. Detailed output of licensecheck in /home/rbarlow/reviews/1386774-kf5-libktorrent/licensecheck.txt randy: It sounds like we should set the license field to "BSD, MIT, and GPLv2+" [!]: License file installed when any subpackage combination is installed. randy: Same as above, let's add the %license macro to both subpackages. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/locale/hne, /usr/share/locale/hne/LC_MESSAGES randy: I'm not sure what to do on this one. It seems that filesystem owns the other directories. Perhaps we should file a ticket against that package to request this hne locale be added? [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/include/KF5, /usr/share/locale/hne/LC_MESSAGES, /usr/share/locale/hne randy: I think adding Requires: kf5-filesystem will fix this one. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. randy: I think we just need a Requires: kf5-filesystem [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== randy: [!]: The URL field didn't seem to work for me. I recommend using https://cgit.kde.org/libktorrent.git/ instead. Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in kf5 -libktorrent-debuginfo [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. randy: I recommend adding comments above the patches with links and/or explanations. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== randy: [!]: You've got two patches that start with 0001-. Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: kf5-libktorrent-2.0.1-4.fc26.x86_64.rpm kf5-libktorrent-devel-2.0.1-4.fc26.x86_64.rpm kf5-libktorrent-debuginfo-2.0.1-4.fc26.x86_64.rpm kf5-libktorrent-2.0.1-4.fc26.src.rpm kf5-libktorrent.x86_64: W: no-documentation kf5-libktorrent-devel.x86_64: W: only-non-binary-in-usr-lib kf5-libktorrent-devel.x86_64: W: no-documentation kf5-libktorrent.src: W: patch-fuzz-is-changed 4 packages and 0 specfiles checked; 0 errors, 4 warnings. Rpmlint (debuginfo) ------------------- Checking: kf5-libktorrent-debuginfo-2.0.1-4.fc26.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- kf5-libktorrent-devel.x86_64: W: only-non-binary-in-usr-lib kf5-libktorrent-devel.x86_64: W: no-documentation kf5-libktorrent.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKF5Torrent.so.6.0.0 /lib64/libKF5Crash.so.5 kf5-libktorrent.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKF5Torrent.so.6.0.0 /lib64/libKF5Solid.so.5 kf5-libktorrent.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKF5Torrent.so.6.0.0 /lib64/libKF5Service.so.5 kf5-libktorrent.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKF5Torrent.so.6.0.0 /lib64/libKF5JobWidgets.so.5 kf5-libktorrent.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKF5Torrent.so.6.0.0 /lib64/libKF5Completion.so.5 kf5-libktorrent.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKF5Torrent.so.6.0.0 /lib64/libKF5WidgetsAddons.so.5 kf5-libktorrent.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKF5Torrent.so.6.0.0 /lib64/libQt5Widgets.so.5 kf5-libktorrent.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKF5Torrent.so.6.0.0 /lib64/libQt5Gui.so.5 kf5-libktorrent.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 11 warnings. Requires -------- kf5-libktorrent-devel (rpmlib, GLIBC filtered): boost-devel cmake(KF5Archive) cmake(KF5Config) cmake(KF5KIO) cmake(Qt5Network) gmp-devel(x86-64) kf5-libktorrent(x86-64) libKF5Torrent.so.6()(64bit) libgcrypt-devel kf5-libktorrent (rpmlib, GLIBC filtered): /sbin/ldconfig libKF5Archive.so.5()(64bit) libKF5Completion.so.5()(64bit) libKF5ConfigCore.so.5()(64bit) libKF5CoreAddons.so.5()(64bit) libKF5Crash.so.5()(64bit) libKF5I18n.so.5()(64bit) libKF5JobWidgets.so.5()(64bit) libKF5KIOCore.so.5()(64bit) libKF5KIOWidgets.so.5()(64bit) libKF5Service.so.5()(64bit) libKF5Solid.so.5()(64bit) libKF5WidgetsAddons.so.5()(64bit) libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.7)(64bit) libQt5Gui.so.5()(64bit) libQt5Network.so.5()(64bit) libQt5Network.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Xml.so.5()(64bit) libQt5Xml.so.5(Qt_5)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcrypt.so.20()(64bit) libgcrypt.so.20(GCRYPT_1.6)(64bit) libgmp.so.10()(64bit) libm.so.6()(64bit) libqca-qt5.so.2()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) rtld(GNU_HASH) kf5-libktorrent-debuginfo (rpmlib, GLIBC filtered): Provides -------- kf5-libktorrent-devel: cmake(KF5Torrent) kf5-libktorrent-devel kf5-libktorrent-devel(x86-64) kf5-libktorrent: kf5-libktorrent kf5-libktorrent(x86-64) libKF5Torrent.so.6()(64bit) kf5-libktorrent-debuginfo: kf5-libktorrent-debuginfo kf5-libktorrent-debuginfo(x86-64) Source checksums ---------------- http://download.kde.org/stable/ktorrent/5.0/libktorrent-2.0.1.tar.xz : CHECKSUM(SHA256) this package : c70d9ee11a1ac95145284e2ab9aec689df21b7462f389389b8d54f892a273f42 CHECKSUM(SHA256) upstream package : c70d9ee11a1ac95145284e2ab9aec689df21b7462f389389b8d54f892a273f42 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1386774 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx