[Bug 1394969] Review Request: python-pluginbase - A support library for building plugins systems

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1394969



--- Comment #2 from Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> ---
Thanks for your review.

(In reply to Athos Ribeiro from comment #1)
> As you can see in [1], ..."You should not include the directories
> %{python3_sitearch}/__pycache__ or %{python3_sitelib}/__pycache__ because
> they are already owned by the python3-libs package."
> 
>  The package owns
> 
> /usr/lib/python3.5/site-packages/__pycache__
> 
> when it should not.
> 
> I believe it would be better to be a little more verbose with the wildcards
> to avoid these kinds of problem.

Thanks. I missed that. The ownership should be fixed now.

> There is a %check section in the spec file, but during the build, tests are
> not being executed at all.
> 
> If you BuildRequires make and pythonX-pytest you could run the test suite
> with `make test`.

Fixed.

Updated files:
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-pluginbase.spec
SRPM URL:
https://fab.fedorapeople.org/packages/SRPMS/python-pluginbase-0.5-2.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]