https://bugzilla.redhat.com/show_bug.cgi?id=1394789 yunying.sun@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |yunying.sun@xxxxxxxxx --- Comment #1 from yunying.sun@xxxxxxxxx --- An informal review: 1. Group & BuildRoot tag should not be used, according to "Tags and Sections" at http://fedoraproject.org/wiki/Packaging:Guidelines 2. File lists is quite long. If all files under a folder are included, is it enough to include the folder only? that is, use: %{_datadir}/nvim/runtime instead of: %dir %{_datadir}/nvim/runtime 3. Better to have rpmlint result and koji build link here. I'm having 2 new packages under review, bug 1369708 and 1369720. Would like a review-swap if possible. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx