[Bug 1395121] Review Request: perl-Crypt-IDEA - Perl interface to IDEA block cipher

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1395121

Petr Pisar <ppisar@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> ---
URL and Source0 addressed are usable. Ok.
Source archive is original (SHA-256:
33bd78c11924a0fc1ff3eedde94078cbbf6b6ca9ede046d2b2f561e9e9a72019). Ok.
License verified from COPYRIGHT.
XS code found, architecture specific package is Ok.
Summary verified from IDEA.pod. Ok.
Description is Ok.
The spec file contains EPEL-5 specific code. Ok.
Build-requires are Ok.
All tests pass. Ok.

$ rpmlint perl-Crypt-IDEA.spec ../SRPMS/perl-Crypt-IDEA-1.10-4.fc26.src.rpm
../RPMS/x86_64/perl-Crypt-IDEA-*
perl-Crypt-IDEA.src: W: spelling-error %description -l en_US BlockCipher ->
Block Cipher, Block-cipher, Decipherable
perl-Crypt-IDEA.x86_64: W: spelling-error %description -l en_US BlockCipher ->
Block Cipher, Block-cipher, Decipherable
3 packages and 1 specfiles checked; 0 errors, 2 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/x86_64/perl-Crypt-IDEA-1.10-4.fc26.x86_64.rpm 
drwxr-xr-x    2 root    root                        0 Nov 15 10:06
/usr/lib64/perl5/vendor_perl/Crypt
-rw-r--r--    1 root    root                     1320 Nov 15 10:06
/usr/lib64/perl5/vendor_perl/Crypt/IDEA.pm
-rw-r--r--    1 root    root                     1877 Dec  8  2005
/usr/lib64/perl5/vendor_perl/Crypt/IDEA.pod
drwxr-xr-x    2 root    root                        0 Nov 15 10:06
/usr/lib64/perl5/vendor_perl/auto/Crypt
drwxr-xr-x    2 root    root                        0 Nov 15 10:06
/usr/lib64/perl5/vendor_perl/auto/Crypt/IDEA
-rwxr-xr-x    1 root    root                    11328 Nov 15 10:06
/usr/lib64/perl5/vendor_perl/auto/Crypt/IDEA/IDEA.so
drwxr-xr-x    2 root    root                        0 Nov 15 10:06
/usr/share/doc/perl-Crypt-IDEA
-rw-r--r--    1 root    root                     1048 Jul 23  2013
/usr/share/doc/perl-Crypt-IDEA/changes
drwxr-xr-x    2 root    root                        0 Nov 15 10:06
/usr/share/licenses/perl-Crypt-IDEA
-rw-r--r--    1 root    root                     2460 Apr 21  2006
/usr/share/licenses/perl-Crypt-IDEA/COPYRIGHT
-rw-r--r--    1 root    root                     1943 Nov 15 10:06
/usr/share/man/man3/Crypt::IDEA.3pm.gz
File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/x86_64/perl-Crypt-IDEA-1.10-4.fc26.x86_64.rpm |
sort -f | uniq -c
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 libc.so.6(GLIBC_2.4)(64bit)
      1 libperl.so.5.24()(64bit)
      1 perl(:MODULE_COMPAT_5.24.0)
      1 perl(Carp)
      1 perl(DynaLoader)
      1 perl(Exporter)
      1 perl(strict)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      1 rtld(GNU_HASH)
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/x86_64/perl-Crypt-IDEA-1.10-4.fc26.x86_64.rpm |
sort -f | uniq -c
      1 perl(Crypt::IDEA) = 1.10
      1 perl(IDEA) = 1.10
      1 perl-Crypt-IDEA = 1.10-4.fc26
      1 perl-Crypt-IDEA(x86-64) = 1.10-4.fc26
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/x86_64/perl-Crypt-IDEA-1.10-4.fc26.x86_64.rpm 
Binary dependencies resolvable. Ok.

Package builds in F26
(http://koji.fedoraproject.org/koji/taskinfo?taskID=16460071). Ok.

Package is in line with Fedora and Perl packaging guidelines.

Resolution: Package APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]