[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1187084



--- Comment #25 from gil cattaneo <puntogil@xxxxxxxxx> ---
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[?]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "MIT/X11 (BSD like)", "BSD (2 clause)", "*No copyright* MIT/X11
     (BSD like)", "Unknown or generated". 107 files have unknown license.
     Detailed output of licensecheck in
     /home/gil/1187084-electrum/licensecheck.txt

BSD (2 clause)
--------------
Electrum-2.7.12/lib/socks.py

Unknown or generated
--------------------
Electrum-2.7.12/gui/kivy/i18n.py
Electrum-2.7.12/gui/kivy/main_window.py
Electrum-2.7.12/gui/kivy/nfc_scanner/scanner_android.py
Electrum-2.7.12/gui/kivy/nfc_scanner/scanner_dummy.py
Electrum-2.7.12/gui/kivy/uix/combobox.py
Electrum-2.7.12/gui/kivy/uix/context_menu.py
Electrum-2.7.12/gui/kivy/uix/dialogs/amount_dialog.py
Electrum-2.7.12/gui/kivy/uix/dialogs/bump_fee_dialog.py
Electrum-2.7.12/gui/kivy/uix/dialogs/checkbox_dialog.py
Electrum-2.7.12/gui/kivy/uix/dialogs/choice_dialog.py
Electrum-2.7.12/gui/kivy/uix/dialogs/fee_dialog.py
Electrum-2.7.12/gui/kivy/uix/dialogs/fx_dialog.py
Electrum-2.7.12/gui/kivy/uix/dialogs/installwizard.py
Electrum-2.7.12/gui/kivy/uix/dialogs/label_dialog.py
Electrum-2.7.12/gui/kivy/uix/dialogs/nfc_transaction.py
Electrum-2.7.12/gui/kivy/uix/dialogs/password_dialog.py
Electrum-2.7.12/gui/kivy/uix/dialogs/qr_dialog.py
Electrum-2.7.12/gui/kivy/uix/dialogs/qr_scanner.py
Electrum-2.7.12/gui/kivy/uix/dialogs/question.py
Electrum-2.7.12/gui/kivy/uix/dialogs/seed_options.py
Electrum-2.7.12/gui/kivy/uix/dialogs/settings.py
Electrum-2.7.12/gui/kivy/uix/dialogs/tx_dialog.py
Electrum-2.7.12/gui/kivy/uix/dialogs/wallets.py
Electrum-2.7.12/gui/kivy/uix/drawer.py
Electrum-2.7.12/gui/kivy/uix/gridview.py
Electrum-2.7.12/gui/kivy/uix/menus.py
Electrum-2.7.12/gui/kivy/uix/qrcodewidget.py
Electrum-2.7.12/gui/kivy/uix/screens.py
Electrum-2.7.12/gui/qt/amountedit.py
Electrum-2.7.12/gui/qt/console.py
Electrum-2.7.12/gui/qt/icons_rc.py
Electrum-2.7.12/gui/qt/installwizard.py
Electrum-2.7.12/gui/qt/qrcodewidget.py
Electrum-2.7.12/gui/qt/qrtextedit.py
Electrum-2.7.12/gui/qt/util.py
Electrum-2.7.12/gui/stdio.py
Electrum-2.7.12/gui/text.py
Electrum-2.7.12/lib/msqr.py
Electrum-2.7.12/lib/paymentrequest_pb2.py
Electrum-2.7.12/lib/simple_config.py
Electrum-2.7.12/lib/tests/test_account.py
Electrum-2.7.12/lib/tests/test_bitcoin.py
Electrum-2.7.12/lib/tests/test_interface.py
Electrum-2.7.12/lib/tests/test_mnemonic.py
Electrum-2.7.12/lib/tests/test_simple_config.py
Electrum-2.7.12/lib/tests/test_transaction.py
Electrum-2.7.12/lib/tests/test_util.py
Electrum-2.7.12/lib/tests/test_wallet.py
Electrum-2.7.12/lib/version.py
Electrum-2.7.12/plugins/audio_modem/qt.py
Electrum-2.7.12/plugins/exchange_rate/exchange_rate.py
Electrum-2.7.12/plugins/exchange_rate/kivy.py
Electrum-2.7.12/plugins/exchange_rate/qt.py
Electrum-2.7.12/plugins/keepkey/client.py
Electrum-2.7.12/plugins/keepkey/cmdline.py
Electrum-2.7.12/plugins/keepkey/keepkey.py
Electrum-2.7.12/plugins/keepkey/qt.py
Electrum-2.7.12/plugins/labels/kivy.py
Electrum-2.7.12/plugins/labels/labels.py
Electrum-2.7.12/plugins/labels/qt.py
Electrum-2.7.12/plugins/ledger/cmdline.py
Electrum-2.7.12/plugins/ledger/ledger.py
Electrum-2.7.12/plugins/ledger/qt.py
Electrum-2.7.12/plugins/plot/qt.py
Electrum-2.7.12/plugins/trezor/client.py
Electrum-2.7.12/plugins/trezor/clientbase.py
Electrum-2.7.12/plugins/trezor/cmdline.py
Electrum-2.7.12/plugins/trezor/plugin.py
Electrum-2.7.12/plugins/trezor/qt.py
Electrum-2.7.12/plugins/trezor/qt_generic.py
Electrum-2.7.12/plugins/trezor/trezor.py
Electrum-2.7.12/plugins/trustedcoin/cmdline.py
Electrum-2.7.12/plugins/virtualkeyboard/qt.py
Electrum-2.7.12/scripts/bip70
Electrum-2.7.12/scripts/block_headers
Electrum-2.7.12/scripts/estimate_fee
Electrum-2.7.12/scripts/get_chunk
Electrum-2.7.12/scripts/get_donation_address
Electrum-2.7.12/scripts/get_history
Electrum-2.7.12/scripts/peers
Electrum-2.7.12/scripts/servers
Electrum-2.7.12/scripts/txradar
Electrum-2.7.12/scripts/util.py
Electrum-2.7.12/scripts/watch_address
Electrum-2.7.12/setup-release.py



[?]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/locale/hy_AM,
     /usr/share/locale/eo_UY, /usr/share/locale/ky_KG/LC_MESSAGES,
     /usr/share/locale/ar_SA/LC_MESSAGES,
     /usr/share/locale/eo_UY/LC_MESSAGES, /usr/share/locale/ar_SA,
     /usr/share/locale/ky_KG, /usr/share/locale/hy_AM/LC_MESSAGES
[?]: Package must own all directories that it creates.
     Note: Directories without known owners:
     /usr/share/locale/eo_UY/LC_MESSAGES, /usr/share/locale/hy_AM,
     /usr/share/locale/eo_UY, /usr/share/locale/ar_SA,
     /usr/share/locale/ky_KG, /usr/share/locale/ky_KG/LC_MESSAGES,
     /usr/share/locale/ar_SA/LC_MESSAGES,
     /usr/share/locale/hy_AM/LC_MESSAGES
[x]: Package contains no bundled libraries without FPC exception.
[?]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[?]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: update-desktop-database is invoked in %post and %postun if package
     contains desktop file(s) with a MimeType: entry.
     Note: desktop file(s) with MimeType entry in electrum
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 40960 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
     desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[?]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).
     See: (this test has no URL)
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: electrum-2.7.12-2.fc26.noarch.rpm
          electrum-2.7.12-2.fc26.src.rpm
electrum.noarch: W: no-manual-page-for-binary electrum
electrum.src:38: W: setup-not-quiet
2 packages and 0 specfiles checked; 0 errors, 2 warnings.




Rpmlint (installed packages)
----------------------------
electrum.noarch: W: no-manual-page-for-binary electrum
1 packages and 0 specfiles checked; 0 errors, 1 warnings.



Diff spec file in url and in SRPM
---------------------------------
--- /home/gil/1187084-electrum/srpm/electrum.spec    2016-11-14
18:06:42.939626718 +0100
+++ /home/gil/1187084-electrum/srpm-unpacked/electrum.spec    2016-11-14
00:52:40.000000000 +0100
@@ -1,5 +1,5 @@
 Name:           electrum
 Version:        2.7.12
-Release:        1%{?dist}
+Release:        2%{?dist}
 Summary:        A lightweight Bitcoin Client

@@ -7,4 +7,5 @@
 URL:            https://electrum.org/
 Source0:       
https://download.electrum.org/%{version}/Electrum-%{version}.tar.gz
+Patch0:         zbar-installation-instructions.patch
 BuildArch:      noarch

@@ -25,4 +26,6 @@
 Requires:       PyQt4

+Suggests:       zbar-pygtk
+
 %description
 Electrum is an easy to use Bitcoin client. It protects you from losing
@@ -33,5 +36,6 @@

 %prep
-%setup -q -n Electrum-%{version}
+%setup -n Electrum-%{version}
+%patch0
 rm -rf Electrum.egg-info
 rm -rf packages
@@ -42,4 +46,6 @@

 %install
+install -d %{buildroot}/usr/share/locale
+mv lib/locale %{buildroot}/usr/share
 %{py2_install}

@@ -82,4 +88,7 @@

 %changelog
+* Sun Nov 13 2016 Jonny Heggheim <jonnyheggheim@xxxxxxxxxxx> - 2.7.12-2
+- Added weak dependency on zbar-pygtk
+
 * Wed Nov 09 2016 Jonny Heggheim <jonnyheggheim@xxxxxxxxxxx> - 2.7.12-1
 - new version


Requires
--------
electrum (rpmlib, GLIBC filtered):
    /bin/sh
    /usr/bin/python2
    PyQt4
    protobuf-python
    python(abi)
    python-dns
    python-ecdsa
    python-jsonrpclib
    python-pbkdf2
    python-qrcode
    python-requests
    python-slowaes
    python2



Provides
--------
electrum:
    application()
    application(electrum.desktop)
    electrum
    mimehandler(x-scheme-handler/bitcoin)
    python2.7dist(electrum)
    python2dist(electrum)



Source checksums
----------------
https://download.electrum.org/2.7.12/Electrum-2.7.12.tar.gz :
  CHECKSUM(SHA256) this package     :
3644274231326cc6b13a25703ebe6ec22bbbce7832a86d75abc745040475ad6f
  CHECKSUM(SHA256) upstream package :
3644274231326cc6b13a25703ebe6ec22bbbce7832a86d75abc745040475ad6f


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1187084 --plugins Python -m
fedora-rawhide-i386 -L ~/deps
Buildroot used: fedora-rawhide-i386
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Built with local dependencies:
    ~/deps/python2-pbkdf2-1.3-5.fc26.noarch.rpm
    ~/deps/python2-slowaes-0.1a1-6.fc26.noarch.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]