https://bugzilla.redhat.com/show_bug.cgi?id=1394046 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zbyszek@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx Flags| |fedora-review+ --- Comment #2 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- All this applies to the "upstream" python-netaddr.spec too, it'd be best to fix it there too: %description is too long to be repeated, it should be defined as a macro. %{__sed} → sed [https://fedoraproject.org/wiki/Packaging:Guidelines#Macros]. " :-" is strange... rpmlint: python34-netaddr.noarch: E: wrong-script-interpreter /usr/bin/netaddr-3.4 /usr/bin/env python python34-netaddr.noarch: W: install-file-in-docs /usr/share/doc/python34-netaddr-0.7.18/INSTALL Those are both valid. Anyway: + package name is OK + license is acceptable (BSD) + license is specified correctly + builds and installs OK + provides/requires look correct + no scriptlets + python macros are used + %python_provide is not needed for EPEL Package is APPROVED. Please consider cleaning up stuff listed above. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx