[Bug 1117961] Review Request: lua-msgpack - Lua binary-based efficient object serialization library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1117961

Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zbyszek@xxxxxxxxx



--- Comment #6 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
Building the srpm does not work if lua is not installed. I think you need to
wrap the ">= %{luaver}" part in a conditional that checks if luaver is defined.

+ package name is OK
+ license is acceptable (MIT)
+ license is specified correctly
- latest version, no 0.3.5 has been released
+ builds and install OK (once lua is manually installed)
+ provides/requires look correct
+ fedora-review is happy

Please update.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]