https://bugzilla.redhat.com/show_bug.cgi?id=1358959 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zbyszek@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx Flags| |fedora-review? --- Comment #5 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- SRPM link gives 404. nsntrace.x86_64: E: incorrect-fsf-address /usr/share/licenses/nsntrace/LICENSE It's nicer to put each BuildRequires on a separate line (better legibility and diffability). The package is nice and simple, really pleasant to review. + latest version + license is acceptable (GPLv2+) + license is specified correctl + builds and installs OK + provides/requires look correct I'll approve the package once you are added to the packagers group. -- I can sponsor you into the packagers group. In addition to the package that you are submitting, I require two-three reviews of other packages (see http://fedoraproject.org/PackageReviewStatus/NEW.html). There's plenty of packages awaiting review, so you should be able to find something interesting without any trouble. In your review, please indicate that you are not a packager yet, hence the review is unofficial. If nobody beats you to it, you'll be able to finalize those reviews after you become a packager (hopefully soon ;)). Building in mock and/or running fedora-review and carefully looking at the output is a good start. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx