Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: linkchecker - checks HTML documents for broken links https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247930 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-07-12 02:18 EST ------- Created an attachment (id=159034) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=159034&action=view) mock build log of linkchecker 4.7-1 on rawhide i386 Some comments. * SourceURL - For sourceforge source, please check the section "Sourceforge.net" of: http://fedoraproject.org/wiki/Packaging/SourceURL * Mock build fails (build log attached) - Note: Now .pyo, .pyc must not be excluded. * File entry - The two lines ---------------------------------------------- %dir %{_datadir}/linkchecker/ %{_datadir}/linkchecker/* ---------------------------------------------- can be replaced with one line: ---------------------------------------------- %{_datadir}/linkchecker/ ---------------------------------------------- - And similarly, IMO the part # Collate list of python files can be removed and can be simplified. * ExcludeArch ---------------------------------------------- # Do not have one of these to test on: ExcludeArch: x86_64 ---------------------------------------------- - What do you mean by this? (see "sitearch" comment below) * sitearch - .so module is arch-dependent and should be installed under site_arch directory (on x86_64 and ppc64, site_lib and site_arch directory differs) * Requires - Check Requires for this package * For example, this package requires python-docutils * python-imaging is available on Fedora * And maybe this package requires more packages. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review