https://bugzilla.redhat.com/show_bug.cgi?id=1376511 Jared Wallace <jared-wallace@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jared-wallace@xxxxxxxxxx --- Comment #6 from Jared Wallace <jared-wallace@xxxxxxxxxx> --- (This is an unofficial review) I'll throw some notes out first, but do also review the automated tool output below, as it identified a large quantity of issues as well. 1) You can remove the line "rm -rf $RPM_BUILD_ROOT" from %install 2) You've got a small ton of rpmlint errors that will either need fixing or explaining (ignore spelling issues unless it really is mispelled) 3) If you have questions about any of the issues listed below, let me know and I'll try to help you solve them. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/doc/NeXus/README.doc See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles - Static libraries in -static or -devel subpackage, providing -devel if present. Note: Package has .a files: nexus. Illegal package name: nexus. Does not provide -static: nexus. See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries - ldconfig called in %post and %postun if required. Note: /sbin/ldconfig not called in nexus See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE is not marked as %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2) (with incorrect FSF address)", "*No copyright* GPL (v2)", "Unknown or generated", "MIT/X11 (BSD like)", "LGPL (v2 or later) (with incorrect FSF address)", "GPL (v2 or later) (with incorrect FSF address)", "*No copyright* LGPL (v2 or later) (with incorrect FSF address)", "GPL (v2)". 185 files have unknown license. Detailed output of licensecheck in /tmp/pkg- review/nexus/nexus/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib64/pkgconfig(pkgconfig), /usr/share/man/man1(filesystem) [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 81920 bytes in 13 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in nexus- debuginfo [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: nexus-4.4.3-2.fc24.x86_64.rpm nexus-devel-4.4.3-2.fc24.x86_64.rpm nexus-tools-4.4.3-2.fc24.x86_64.rpm nexus-debuginfo-4.4.3-2.fc24.x86_64.rpm nexus-4.4.3-2.fc24.src.rpm nexus.x86_64: E: explicit-lib-dependency libgfortran nexus.x86_64: W: name-repeated-in-summary C NeXus nexus.x86_64: W: spelling-error %description -l en_US muon -> mun, moon, mu on nexus.x86_64: W: shared-lib-calls-exit /usr/lib64/libNeXus77.so.1.0.0 exit@GLIBC_2.2.5 nexus.x86_64: W: shared-lib-calls-exit /usr/lib64/libNeXus.so.1.0.0 exit@GLIBC_2.2.5 nexus.x86_64: W: shared-lib-calls-exit /usr/lib64/libNeXus90.so.1.0.0 exit@GLIBC_2.2.5 nexus.x86_64: W: shared-lib-calls-exit /usr/lib64/libNeXusCPP.so.1.0.0 exit@GLIBC_2.2.5 nexus.x86_64: E: library-without-ldconfig-postin /usr/lib64/libNeXus77.so.1.0.0 nexus.x86_64: E: library-without-ldconfig-postun /usr/lib64/libNeXus77.so.1.0.0 nexus.x86_64: W: devel-file-in-non-devel-package /usr/lib64/nexus/libNeXus77.a nexus.x86_64: W: devel-file-in-non-devel-package /usr/lib64/nexus/libNeXus90.a nexus.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libNeXusCPP.so nexus.x86_64: E: library-without-ldconfig-postin /usr/lib64/libNeXus.so.1.0.0 nexus.x86_64: E: library-without-ldconfig-postun /usr/lib64/libNeXus.so.1.0.0 nexus.x86_64: E: library-without-ldconfig-postin /usr/lib64/libNeXus90.so.1.0.0 nexus.x86_64: E: library-without-ldconfig-postun /usr/lib64/libNeXus90.so.1.0.0 nexus.x86_64: E: library-without-ldconfig-postin /usr/lib64/libNeXusCPP.so.1.0.0 nexus.x86_64: E: library-without-ldconfig-postun /usr/lib64/libNeXusCPP.so.1.0.0 nexus.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libNeXus.a nexus.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libNeXus.so nexus.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libNeXus77.so nexus.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libNeXusCPP.a nexus.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libNeXus90.so nexus-devel.x86_64: W: only-non-binary-in-usr-lib nexus-devel.x86_64: W: no-documentation nexus-devel.x86_64: E: incorrect-fsf-address /usr/include/nexus/napiu.h nexus-devel.x86_64: E: incorrect-fsf-address /usr/include/nexus/napi.h nexus-tools.x86_64: E: explicit-lib-dependency libxml2 nexus-tools.x86_64: W: summary-ended-with-dot C Applications for reading and writing NeXus files. nexus-tools.x86_64: E: standard-dir-owned-by-package /usr/share/man/man1 nexus-tools.x86_64: W: no-manual-page-for-binary nxingest nexus-tools.x86_64: W: no-manual-page-for-binary nxtraverse nexus-tools.x86_64: W: no-manual-page-for-binary nxtranslate nexus-debuginfo.x86_64: E: script-without-shebang /usr/src/debug/code-4.4.3/bindings/f90/NXmodule.f90 nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/include/napi_internal.h nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/src/napiu.c nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/applications/NXtranslate/tree.hh nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/applications/NXconvert/nxconvert_common.cpp nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/src/napi_fortran_helper.c nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/include/napi.h nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/src/napi4.c nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/src/nxstack.c nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/src/nxstack.h nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/src/napi5.c nexus-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/code-4.4.3/src/stptok.c nexus-debuginfo.x86_64: E: script-without-shebang /usr/src/debug/code-4.4.3/bindings/f90/NXUmodule.f90 nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/applications/NXconvert/nxconvert.cpp nexus-debuginfo.x86_64: E: script-without-shebang /usr/src/debug/code-4.4.3/applications/NXdump/NXdump.f90 nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/applications/NXbrowse/NXbrowse.c nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/src/napi.c nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/applications/NXconvert/nxconvert_common.h nexus.src: W: name-repeated-in-summary C NeXus nexus.src: W: spelling-error %description -l en_US muon -> mun, moon, mu on 5 packages and 0 specfiles checked; 30 errors, 23 warnings. Rpmlint (debuginfo) ------------------- Checking: nexus-debuginfo-4.4.3-2.fc24.x86_64.rpm nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/src/napi.c nexus-debuginfo.x86_64: E: script-without-shebang /usr/src/debug/code-4.4.3/applications/NXdump/NXdump.f90 nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/applications/NXtranslate/tree.hh nexus-debuginfo.x86_64: E: script-without-shebang /usr/src/debug/code-4.4.3/bindings/f90/NXmodule.f90 nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/src/napiu.c nexus-debuginfo.x86_64: E: script-without-shebang /usr/src/debug/code-4.4.3/bindings/f90/NXUmodule.f90 nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/applications/NXbrowse/NXbrowse.c nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/include/napi.h nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/src/napi5.c nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/applications/NXconvert/nxconvert.cpp nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/src/napi_fortran_helper.c nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/src/nxstack.c nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/src/napi4.c nexus-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/code-4.4.3/src/stptok.c nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/applications/NXconvert/nxconvert_common.cpp nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/include/napi_internal.h nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/src/nxstack.h nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/applications/NXconvert/nxconvert_common.h 1 packages and 0 specfiles checked; 17 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory nexus.x86_64: E: explicit-lib-dependency libgfortran nexus.x86_64: W: name-repeated-in-summary C NeXus nexus.x86_64: W: spelling-error %description -l en_US muon -> mun, moon, mu on nexus.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libNeXusCPP.so.1.0.0 /lib64/libmxml.so.1 nexus.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libNeXusCPP.so.1.0.0 /lib64/libhdf5_cpp.so.11 nexus.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libNeXusCPP.so.1.0.0 /lib64/libhdf5.so.10 nexus.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libNeXusCPP.so.1.0.0 /lib64/libdl.so.2 nexus.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libNeXusCPP.so.1.0.0 /lib64/libm.so.6 nexus.x86_64: W: shared-lib-calls-exit /usr/lib64/libNeXusCPP.so.1.0.0 exit@GLIBC_2.2.5 nexus.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libNeXus90.so.1.0.0 /lib64/libmxml.so.1 nexus.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libNeXus90.so.1.0.0 /lib64/libhdf5_cpp.so.11 nexus.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libNeXus90.so.1.0.0 /lib64/libhdf5.so.10 nexus.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libNeXus90.so.1.0.0 /lib64/libdl.so.2 nexus.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libNeXus90.so.1.0.0 /lib64/libm.so.6 nexus.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libNeXus90.so.1.0.0 /lib64/libgcc_s.so.1 nexus.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libNeXus90.so.1.0.0 /lib64/libquadmath.so.0 nexus.x86_64: W: shared-lib-calls-exit /usr/lib64/libNeXus90.so.1.0.0 exit@GLIBC_2.2.5 nexus.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libNeXus.so.1.0.0 /lib64/libhdf5_cpp.so.11 nexus.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libNeXus.so.1.0.0 /lib64/libdl.so.2 nexus.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libNeXus.so.1.0.0 /lib64/libm.so.6 nexus.x86_64: W: shared-lib-calls-exit /usr/lib64/libNeXus.so.1.0.0 exit@GLIBC_2.2.5 nexus.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libNeXus77.so.1.0.0 /lib64/libmxml.so.1 nexus.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libNeXus77.so.1.0.0 /lib64/libhdf5_cpp.so.11 nexus.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libNeXus77.so.1.0.0 /lib64/libhdf5.so.10 nexus.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libNeXus77.so.1.0.0 /lib64/libdl.so.2 nexus.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libNeXus77.so.1.0.0 /lib64/libm.so.6 nexus.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libNeXus77.so.1.0.0 /lib64/libgcc_s.so.1 nexus.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libNeXus77.so.1.0.0 /lib64/libquadmath.so.0 nexus.x86_64: W: shared-lib-calls-exit /usr/lib64/libNeXus77.so.1.0.0 exit@GLIBC_2.2.5 nexus.x86_64: E: library-without-ldconfig-postin /usr/lib64/libNeXusCPP.so.1.0.0 nexus.x86_64: E: library-without-ldconfig-postun /usr/lib64/libNeXusCPP.so.1.0.0 nexus.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libNeXus.a nexus.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libNeXus.so nexus.x86_64: E: library-without-ldconfig-postin /usr/lib64/libNeXus90.so.1.0.0 nexus.x86_64: E: library-without-ldconfig-postun /usr/lib64/libNeXus90.so.1.0.0 nexus.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libNeXusCPP.so nexus.x86_64: W: devel-file-in-non-devel-package /usr/lib64/nexus/libNeXus77.a nexus.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libNeXusCPP.a nexus.x86_64: E: library-without-ldconfig-postin /usr/lib64/libNeXus.so.1.0.0 nexus.x86_64: E: library-without-ldconfig-postun /usr/lib64/libNeXus.so.1.0.0 nexus.x86_64: W: devel-file-in-non-devel-package /usr/lib64/nexus/libNeXus90.a nexus.x86_64: E: library-without-ldconfig-postin /usr/lib64/libNeXus77.so.1.0.0 nexus.x86_64: E: library-without-ldconfig-postun /usr/lib64/libNeXus77.so.1.0.0 nexus.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libNeXus90.so nexus.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libNeXus77.so nexus-tools.x86_64: E: explicit-lib-dependency libxml2 nexus-tools.x86_64: W: summary-ended-with-dot C Applications for reading and writing NeXus files. nexus-tools.x86_64: E: standard-dir-owned-by-package /usr/share/man/man1 nexus-tools.x86_64: W: no-manual-page-for-binary nxingest nexus-tools.x86_64: W: no-manual-page-for-binary nxtranslate nexus-tools.x86_64: W: no-manual-page-for-binary nxtraverse nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/include/napi.h nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/src/napi.c nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/applications/NXconvert/nxconvert.cpp nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/src/napi4.c nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/applications/NXbrowse/NXbrowse.c nexus-debuginfo.x86_64: E: script-without-shebang /usr/src/debug/code-4.4.3/bindings/f90/NXmodule.f90 nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/src/nxstack.c nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/src/nxstack.h nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/src/napi5.c nexus-debuginfo.x86_64: E: script-without-shebang /usr/src/debug/code-4.4.3/applications/NXdump/NXdump.f90 nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/include/napi_internal.h nexus-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/code-4.4.3/src/stptok.c nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/applications/NXconvert/nxconvert_common.cpp nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/src/napiu.c nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/applications/NXtranslate/tree.hh nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/applications/NXconvert/nxconvert_common.h nexus-debuginfo.x86_64: E: script-without-shebang /usr/src/debug/code-4.4.3/bindings/f90/NXUmodule.f90 nexus-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/code-4.4.3/src/napi_fortran_helper.c nexus-devel.x86_64: W: only-non-binary-in-usr-lib nexus-devel.x86_64: W: no-documentation nexus-devel.x86_64: E: incorrect-fsf-address /usr/include/nexus/napiu.h nexus-devel.x86_64: E: incorrect-fsf-address /usr/include/nexus/napi.h 4 packages and 0 specfiles checked; 30 errors, 43 warnings. Requires -------- nexus (rpmlib, GLIBC filtered): hdf hdf5 libNeXus.so.1()(64bit) libNeXus77.so.1()(64bit) libNeXus90.so.1()(64bit) libNeXusCPP.so.1()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgfortran libgfortran.so.3()(64bit) libgfortran.so.3(GFORTRAN_1.0)(64bit) libgfortran.so.3(GFORTRAN_1.1)(64bit) libgfortran.so.3(GFORTRAN_1.4)(64bit) libhdf5.so.10()(64bit) libhdf5_cpp.so.11()(64bit) libjpeg.so.62()(64bit) libjpeg.so.62(LIBJPEG_6.2)(64bit) libm.so.6()(64bit) libmxml.so.1()(64bit) libpthread.so.0()(64bit) libquadmath.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libz.so.1()(64bit) mxml rtld(GNU_HASH) nexus-tools (rpmlib, GLIBC filtered): libNeXus.so.1()(64bit) libNeXus90.so.1()(64bit) libNeXusCPP.so.1()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgfortran.so.3()(64bit) libgfortran.so.3(GFORTRAN_1.0)(64bit) libgfortran.so.3(GFORTRAN_1.4)(64bit) libhdf5.so.10()(64bit) libhdf5_cpp.so.11()(64bit) libjpeg.so.62()(64bit) libjpeg.so.62(LIBJPEG_6.2)(64bit) libm.so.6()(64bit) libmxml.so.1()(64bit) libpthread.so.0()(64bit) libquadmath.so.0()(64bit) libreadline.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libxml2 libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libxml2.so.2(LIBXML2_2.6.0)(64bit) libz.so.1()(64bit) nexus(x86-64) readline rtld(GNU_HASH) nexus-debuginfo (rpmlib, GLIBC filtered): nexus-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config hdf-devel hdf5-devel mxml-devel nexus(x86-64) pkgconfig(nexus) Provides -------- nexus: libNeXus.so.1()(64bit) libNeXus77.so.1()(64bit) libNeXus90.so.1()(64bit) libNeXusCPP.so.1()(64bit) nexus nexus(x86-64) nexus-tools: nexus-tools nexus-tools(x86-64) nexus-debuginfo: nexus-debuginfo nexus-debuginfo(x86-64) nexus-devel: nexus-devel nexus-devel(x86-64) pkgconfig(nexus) pkgconfig(nexus-cpp) pkgconfig(nexus-f77) Unversioned so-files -------------------- nexus: /usr/lib64/libNeXus.so nexus: /usr/lib64/libNeXus77.so nexus: /usr/lib64/libNeXus90.so nexus: /usr/lib64/libNeXusCPP.so Source checksums ---------------- https://github.com/nexusformat/code/archive/v4.4.3.tar.gz : CHECKSUM(SHA256) this package : e78a116feb2ebd04de31a8d8707c65e8e15a64aa8999a40fea305e3909bd6533 CHECKSUM(SHA256) upstream package : e78a116feb2ebd04de31a8d8707c65e8e15a64aa8999a40fea305e3909bd6533 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -rn nexus-4.4.3-2.fc26.src.rpm Buildroot used: fedora-24-x86_64 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx