[Bug 1382152] Review Request: orpie - scientific calculator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1382152

Randy Barlow <randy@xxxxxxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(jared-wallace@us.
                   |                            |ibm.com)



--- Comment #7 from Randy Barlow <randy@xxxxxxxxxxxxxxxxxxxxx> ---
Hey Jared! The changes look nice! Two things I noticed in your changelog:

* There's a line that says you added the multi-core, but as you noted it
doesn't build that way so it's not actually added. I think it's OK to not build
multi-core since that doesn't work, so let's just drop that changelog entry.
* Typically people add a space between changelog entries for readability, so
adding one more newline before the Wed Oct 05 line would improve readability.
This is just a suggestion of mine, not a formal requirement, so it's up to you.

Let's fix at least that first one, and then I think this'll be ready to pass
review. Then we can look at some package reviews.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]