[Bug 1394275] Review Request: librdkafka - C/ C++ library implementation of the Apache Kafka protocol

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1394275



--- Comment #6 from Jakub Jelen <jjelen@xxxxxxxxxx> ---
The testsuite requires python

  [librdkafka-0.9.2]$ grep -r "python"
  tests/LibrdkafkaTestApp.py:#!/usr/bin/env python
  [...]

so I guess we need BuildRequires python for the tests.



Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory

> probably bug in fedora-review in rawhide

librdkafka-devel.x86_64: W: only-non-binary-in-usr-lib

> The *.so files in the non-devel should have reasonable permissions (but it does not look like helping the message above). A bug in rpmlint (bug #1251505)?:

> %attr(0644,root,root) %{_libdir}/librdkafka.so.*
> %attr(0644,root,root) %{_libdir}/librdkafka++.so.*

librdkafka-devel.x86_64: W: no-documentation

> We should have some manual page. Though it is not crucial

librdkafka.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/librdkafka++.so.1 /lib64/libz.so.1
librdkafka.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/librdkafka++.so.1 /lib64/librt.so.1

> Make sure the libraries (libz, librt) are used in the code or the proper configure flags are used to build the package with these dependencies.

3 packages and 0 specfiles checked; 0 errors, 4 warnings.

===
Otherwise it looks good

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]