https://bugzilla.redhat.com/show_bug.cgi?id=1393129 Merlin Mathesius <mmathesi@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(mmathesi@redhat.c | |om) | --- Comment #4 from Merlin Mathesius <mmathesi@xxxxxxxxxx> --- Thank you for the additional helpful review comments. I missed the snapshot versioning guidelines. I have now corrected that, along with addressing all of your other comments. I have kept Python 3 support, but am only including the Python 2 version of /usr/bin/aexpect-helper with no renamed versions or symlinks to it--I'll address that when Python 3 support is no longer considered experimental. Regarding the order of running the %py2_install and %py3_install macros, I found that the second one run does *not* overwrite the first /usr/bin/aexpect-helper. Just to avoid the unexpected, I changed the spec to run %py3_install first, remove aexpect-helper, then run %py2_install so only the Python 2 version remains to be go into the python2-aexpect subpackage. New Spec URL: https://merlinm.fedorapeople.org/python-aexpect.spec New SRPM URL: https://merlinm.fedorapeople.org/python-aexpect-1.2.0-2.20161010gitaca459d.fc24.src.rpm New Koji scratch build URL: http://koji.fedoraproject.org/koji/taskinfo?taskID=16388717 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx