https://bugzilla.redhat.com/show_bug.cgi?id=1392606 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- > FIX: Most of binary requires are missing, because perl-generators was not > installed. $ rpm -qp --requires perl-Encode-IMAPUTF7-1.05-2.fc26.noarch.rpm | sort | uniq -c 1 perl(:MODULE_COMPAT_5.24.0) 1 perl(Encode) 1 perl(Encode::Encoding) 1 perl(MIME::Base64) 1 perl(base) 1 perl(strict) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are ok. > FIX: Provides 'erl(Encode::IMAPUTF7) = 1.05 is not listed due to missing > perl-generators $ rpm -qp --provides perl-Encode-IMAPUTF7-1.05-2.fc26.noarch.rpm | sort | uniq -c 1 perl(Encode::IMAPUTF7) = 1.05 1 perl-Encode-IMAPUTF7 = 1.05-2.fc26 Binary provides are ok. > BuildRequires: > FIX: Please add following build-requires: > coreutils - because 'tr', 'mv', 'touch',... are used in spec file It is not necessary to listed. Ok > findutils - 'find' is used in spec file 'find' was removed from spec. Ok > perl - it is used in spec file > perl-generators - is necessary for generating of package provides and > requires. The package is not part of default > buildroot > Encode-IMAPUTF7-1.05/Makefile.PL > perl(base) - lib/Encode/IMAPUTF7.pm:7 > perl(Encode::Encoding) - lib/Encode/IMAPUTF7.pm:7 > perl(File::Basename) - t/0-test.t:12 > perl(File::Spec) - t/0-test.t:13 > perl(MIME::Base64) - lib/Encode/IMAPUTF7.pm:10 > perl(strict) - lib/Encode/IMAPUTF7.pm:5 > perl(Test::More) - t/0-test.t:12 > perl(warnings) - lib/Encode/IMAPUTF7.pm:7 -BuildRequires: perl(Encode) -BuildRequires: perl(ExtUtils::MakeMaker) -BuildRequires: perl(Test::NoWarnings) + +BuildRequires: make perl perl-generators +BuildRequires: perl(base) perl(Encode) perl(Encode::Encoding) +BuildRequires: perl(ExtUtils::MakeMaker) perl(File::Basename) perl(File::Spec) +BuildRequires: perl(MIME::Base64) perl(strict) perl(Test::More) +BuildRequires: perl(Test::NoWarnings) perl(warnings) Ok. > TODO: Please replace PERL_INSTALL_ROOT with more common DESTDIR. -make pure_install PERL_INSTALL_ROOT=%buildroot +make pure_install DESTDIR=%buildroot Ok. > TODO: The easier way to remove .packlist is used NO_PACKLIST option, > which is part of perl(ExtUtils::MakeMaker) >= 6.76. It can be > used in all Fedoras. The command is > %{__perl} Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1 -%{__perl} Makefile.PL INSTALLDIRS=vendor +%{__perl} Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1 Ok. Please add version restriction for perl(ExtUtils::MakeMaker) to require version 6.76 or higher. > TODO: Remove the deleting empty directories in %install section. This is > default behavior for Fedoras. -%global remove_packlist find %buildroot -type f -name .packlist -exec rm -f {} \\; ; find %buildroot -depth -type d -exec rmdir {} 2>/dev/null \\; ... -%remove_packlist Ok. Difference between 'make install' and 'make pure_install is described here. https://fedoraproject.org/wiki/Perl/Tips#ExtUtils::MakeMaker I know that cpanspec is outdated. There are lots of patches, but the upstream does not accept them yet. The package looks good. Approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx